-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer and deployment containers infrastructure #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
GDYendell
commented
Nov 27, 2024
•
edited
Loading
edited
- Depends on Implement ParameterTree #370
@gilesknap could you take a look at this and see if it still matches your recommendations for devcontainers? |
2 tasks
timcnicholls
approved these changes
Dec 5, 2024
gilesknap
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I put some of the latest changes in as suggestions but they are not a must have.
65fa2c1
to
8ecea8f
Compare
695f37a
to
8e800ee
Compare
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <[email protected]>
Update vscode CMake config to install into /odin Add publish of build container. This is used as a base for detector developer containers on where they have the full dev environment but also have odin-data installed in /odin to build against. Add python3.11 install Add hdf5filters install for compression libs
14352d4
to
eab3e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.