Fix/devops root redirect compose

backend/tests/core/TuColmadoRD.Core.Application.Tests/Sales/SalesModuleTests.cs

@@ -9,7 +9,6 @@
 using TuColmadoRD.Core.Domain.Entities.Inventory;
 using TuColmadoRD.Core.Domain.Entities.Sales;
 using TuColmadoRD.Core.Domain.Entities.System;
-using TuColmadoRD.Core.Domain.Enums.Inventory_Purchasing;
 using TuColmadoRD.Core.Domain.ValueObjects;
 using TuColmadoRD.Core.Domain.ValueObjects.Base;
 using TuColmadoRD.Core.Domain.Interfaces.Repositories.Logistics;
@@ -59,6 +58,9 @@ public SalesModuleTests()
             _tenant.Object,
             _shiftService.Object,
             _productRepo.Object,
+            new Mock<IPresentationRepository>().Object,
+            new Mock<IPackagedStockRepository>().Object,
+            new Mock<IStockContainerRepository>().Object,
             _saleRepo.Object,
             _sequence.Object,
             _shiftRepo.Object,
@@ -75,7 +77,6 @@ public SalesModuleTests()
             _tenant.Object,
             _shiftService.Object,
             _saleRepo.Object,
-            _productRepo.Object,
             _shiftRepo.Object,
             _outboxRepo.Object,
             _uow.Object,
@@ -107,7 +108,7 @@ public async Task CreateSale_WithValidItems_ShouldPersistSaleAndCommit()
             .ReturnsAsync(new List<Product> { product }.AsReadOnly());
 
         var command = new CreateSaleCommand(
-            new List<SaleItemRequest> { new(product.Id, 2m) }.AsReadOnly(),
+            new List<SaleItemRequest> { new(product.Id, Guid.NewGuid(), 2m) }.AsReadOnly(),
             new List<SalePaymentRequest> { new(1, 300m, null, null) }.AsReadOnly(),
             null);
 
@@ -131,7 +132,7 @@ public async Task CreateSale_WithoutOpenShift_ShouldReturnShiftNotFoundError()
                 DomainError.Business("shift.not_found", "No hay turno abierto")));
 
         var command = new CreateSaleCommand(
-            new List<SaleItemRequest> { new(Guid.NewGuid(), 1m) }.AsReadOnly(),
+            new List<SaleItemRequest> { new(Guid.NewGuid(), Guid.NewGuid(), 1m) }.AsReadOnly(),
             new List<SalePaymentRequest>().AsReadOnly(),
             null);
 
@@ -219,14 +220,10 @@ private Shift BuildShift()
 
     private Product BuildProduct()
     {
-        var cost     = Money.FromDecimal(80m).Result!;
-        var price    = Money.FromDecimal(100m).Result!;
         var taxRate  = TaxRate.Create(0.18m).Result!;
-        var result   = Product.Create(_tenantId, "Producto Test", Guid.NewGuid(), cost, price, taxRate, UnitType.Unit);
+        var result   = Product.Create(_tenantId, "Producto Test", Guid.NewGuid(), taxRate);
         result.IsGood.Should().BeTrue("el producto de prueba debe crearse sin errores");
-        var product = result.Result!;
-        product.AdjustStock(100m);   // stock inicial para que las ventas puedan descontar
-        return product;
+        return result.Result!;
     }
 
     /// <summary>

backend/tests/core/TuColmadoRD.Core.Domain.Tests/Inventory/ProductTests.cs

@@ -1,7 +1,6 @@
 using FluentAssertions;
 using TuColmadoRD.Core.Domain.Entities.Inventory;
 using TuColmadoRD.Core.Domain.Entities.Inventory.Events;
-using TuColmadoRD.Core.Domain.Enums.Inventory_Purchasing;
 using TuColmadoRD.Core.Domain.ValueObjects;
 
 namespace TuColmadoRD.Tests.Inventory;
@@ -13,95 +12,90 @@ public void Create_WhenDataIsValid_ReturnsProductAndEmitsCreatedEvent()
     {
         var tenantId = Guid.NewGuid();
         var categoryId = Guid.NewGuid();
-        var cost = Money.FromDecimal(50m).Result!;
-        var sale = Money.FromDecimal(75m).Result!;
         var taxRate = TaxRate.Create(0.18m).Result!;
 
-        var result = Product.Create(tenantId, "Coca Cola 2L", categoryId, cost, sale, taxRate, UnitType.Unit);
+        var result = Product.Create(tenantId, "Coca Cola 2L", categoryId, taxRate);
 
         result.IsGood.Should().BeTrue();
-        result.Result.Name.Should().Be("Coca Cola 2L");
+        result.Result!.Name.Should().Be("Coca Cola 2L");
         result.Result.CategoryId.Should().Be(categoryId);
-        result.Result.StockQuantity.Should().Be(0m);
         result.Result.IsActive.Should().BeTrue();
         result.Result.DomainEvents.Should().ContainSingle(e => e is ProductCreatedDomainEvent);
     }
 
     [Fact]
-    public void Create_WhenSalePriceIsBelowCost_ReturnsValidationError()
+    public void Create_WhenNameIsEmpty_ReturnsValidationError()
     {
         var tenantId = Guid.NewGuid();
         var categoryId = Guid.NewGuid();
-        var cost = Money.FromDecimal(80m).Result!;
-        var sale = Money.FromDecimal(70m).Result!;
-        var taxRate = TaxRate.Create(0.18m).Result!;
+        var taxRate = TaxRate.Create(0m).Result!;
+
+        var result = Product.Create(tenantId, "   ", categoryId, taxRate);
+
+        result.IsGood.Should().BeFalse();
+        result.Error!.Code.Should().Be("product.name_required");
+    }
+
+    [Fact]
+    public void Create_WhenTenantIdIsEmpty_ReturnsValidationError()
+    {
+        var categoryId = Guid.NewGuid();
+        var taxRate = TaxRate.Create(0m).Result!;
 
-        var result = Product.Create(tenantId, "Leche", categoryId, cost, sale, taxRate, UnitType.Liter);
+        var result = Product.Create(Guid.Empty, "Leche", categoryId, taxRate);
 
         result.IsGood.Should().BeFalse();
-        result.Error.Code.Should().Be("product.sale_price_below_cost");
+        result.Error!.Code.Should().Be("product.tenant_required");
     }
 
     [Fact]
-    public void UpdatePrice_WhenDataIsValid_UpdatesPricesAndEmitsEvent()
+    public void UpdateName_WhenDataIsValid_UpdatesName()
     {
         var product = CreateValidProduct();
-        var newCost = Money.FromDecimal(60m).Result!;
-        var newSale = Money.FromDecimal(95m).Result!;
 
-        var result = product.UpdatePrice(newCost, newSale);
+        var result = product.UpdateName("Azucar Morena");
 
         result.IsGood.Should().BeTrue();
-        product.CostPrice.Amount.Should().Be(60m);
-        product.SalePrice.Amount.Should().Be(95m);
-        product.DomainEvents.Should().Contain(e => e is ProductPriceUpdatedDomainEvent);
+        product.Name.Should().Be("Azucar Morena");
     }
 
     [Fact]
-    public void AdjustStock_WhenResultWouldBeNegative_ReturnsBusinessError()
+    public void UpdateName_WhenNameIsEmpty_ReturnsValidationError()
     {
         var product = CreateValidProduct();
 
-        var result = product.AdjustStock(-1m);
+        var result = product.UpdateName("   ");
 
         result.IsGood.Should().BeFalse();
-        result.Error.Code.Should().Be("product.insufficient_stock");
-        product.StockQuantity.Should().Be(0m);
+        result.Error!.Code.Should().Be("product.name_required");
+        product.Name.Should().Be("Test Product");
     }
 
     [Fact]
-    public void RehydrateForCatalogSync_SetsGivenIdAndClearsDomainEvents()
+    public void Rehydrate_SetsGivenIdAndHasNoDomainEvents()
     {
         var productId = Guid.NewGuid();
         var tenantId = Guid.NewGuid();
         var categoryId = Guid.NewGuid();
-        var cost = Money.FromDecimal(40m).Result!;
-        var sale = Money.FromDecimal(65m).Result!;
         var taxRate = TaxRate.Create(0.18m).Result!;
 
-        var result = Product.RehydrateForCatalogSync(productId, tenantId, categoryId, "Arroz", cost, sale, taxRate);
+        var product = Product.Rehydrate(productId, tenantId, "Arroz", categoryId, taxRate);
 
-        result.IsGood.Should().BeTrue();
-        result.Result.Id.Should().Be(productId);
-        result.Result.UnitType.Should().Be(UnitType.Unit);
-        result.Result.DomainEvents.Should().BeEmpty();
+        product.Id.Should().Be(productId);
+        product.Name.Should().Be("Arroz");
+        product.DomainEvents.Should().BeEmpty();
     }
 
     [Fact]
-    public void UpdateFromCatalogSync_WhenDataIsValid_UpdatesCoreFields()
+    public void UpdateItbisRate_WhenCalled_UpdatesRate()
     {
         var product = CreateValidProduct();
-        var newCategoryId = Guid.NewGuid();
-        var newCost = Money.FromDecimal(25m).Result!;
-        var newSale = Money.FromDecimal(38m).Result!;
+        var newRate = TaxRate.Create(0.18m).Result!;
 
-        var result = product.UpdateFromCatalogSync(newCategoryId, "  Azucar Morena  ", newCost, newSale);
+        var result = product.UpdateItbisRate(newRate);
 
         result.IsGood.Should().BeTrue();
-        product.Name.Should().Be("Azucar Morena");
-        product.CategoryId.Should().Be(newCategoryId);
-        product.CostPrice.Amount.Should().Be(25m);
-        product.SalePrice.Amount.Should().Be(38m);
+        product.ItbisRate.Should().Be(newRate);
     }
 
     [Fact]
@@ -119,11 +113,9 @@ private static Product CreateValidProduct()
     {
         var tenantId = Guid.NewGuid();
         var categoryId = Guid.NewGuid();
-        var cost = Money.FromDecimal(10m).Result!;
-        var sale = Money.FromDecimal(15m).Result!;
         var taxRate = TaxRate.Create(0.18m).Result!;
 
-        var created = Product.Create(tenantId, "Test Product", categoryId, cost, sale, taxRate, UnitType.Unit);
+        var created = Product.Create(tenantId, "Test Product", categoryId, taxRate);
 
         return created.Result!;
     }

backend/tests/infrastructure/TuColmadoRD.Infrastructure.Persistence.Tests/Phase3/CatalogSyncWorkerTests.cs

@@ -83,14 +83,12 @@ public async Task SyncAsync_WhenCloudReturnsProducts_UpsertsExistingProduct()
         var fakeHandler = new FakeHttpMessageHandler(HttpStatusCode.OK, payload);
         using var setup = CreateSetup(true, fakeHandler, null);
 
-        var existing = Product.RehydrateForCatalogSync(
+        var existing = Product.Rehydrate(
             productId,
-            setup.TenantProvider.TenantId,
-            Guid.NewGuid(),
+            (Guid)setup.TenantProvider.TenantId,
             "Viejo",
-            Money.FromDecimal(0).Result,
-            Money.FromDecimal(100).Result,
-            TaxRate.Create(0).Result).Result;
+            Guid.NewGuid(),
+            TaxRate.Create(0).Result!);
 
         setup.DbContext.Products.Add(existing);
         await setup.DbContext.SaveChangesAsync();