CORE-340: Add openshift.ubi9ImageTags helm value#3753
Conversation
|
Also fixing a "broken link" flake in the otlphttp destination |
| ✅ Traces | ||
| ✅ Metrics | ||
| ❌ Logs | ||
| ✅ Logs |
There was a problem hiding this comment.
This doesn't look right to me, OpsVerse logs was disabled due to the deprecation of lokiexporter from contrib
There was a problem hiding this comment.
I was also confused by the docs changes. This came out of just running the sync-dest-docs script, so maybe there is an issue locally for me on that
There was a problem hiding this comment.
@BenElferink ah the opsverse logs change was reverted https://github.com/odigos-io/odigos/blame/e9f645e3d40c695ae6c108b10f495be25867961f/destinations/data/opsverse.yaml#L15 in #3734
There was a problem hiding this comment.
I'm not sure if there are more places that needs this logic change in the code but one place that comes to mind is: odigos-agents init container we add in the webhhok when the mount method is init-container.
There was a problem hiding this comment.
good catch, I think that does need a similar update in code
otherwise, I think all images come from install at this point right?
There was a problem hiding this comment.
we actually don't have a RH certified odigos-agents image and the initContainer image helper never uses the -ubi9 suffix
4b9bf6a to
325ef97
Compare
Description
This allows users to install with
openshift.enabled=trueusing non-ubi9 images.The expected use case is an OpenShift user who has mirrored their own images, but still needs the additional OpenShift settings (RBAC, selinux permissions, etc)
Setting
openshift.ubi9ImageTags=falsewill not append the-ubi9suffix onto pulled tags. This will only work if the user is not pulling from the Red Hat certified registry (whichopenshift.enabled=trueuses by default), because we only push UBI9 images there.So, the intended use is to combine this with
imagePrefx=docker.io/.....Example:
Install on OpenShift, using non-UBI images from my own registry:
Image format:
docker.io/mikeodigos/odigos-odiglet:v1.xInstall on OpenShift, using UBI images from my own registry:
Image format:
docker.io/mikeodigos/odigos-odiglet-ubi9:v1.x(this is valid for OpenShift users who are mirroring certified images to their clusterInstall on OpenShift, using UBI images from Red Hat:
Image format:
registry.connect.redhat.com/odigos/odigos-collector-ubi9:v0.0.0INVALID: Install on OpenShift, using non-UBI images from Red Hat (will not work):
Image format:
registry.connect.redhat.com/odigos/odigos-collector:v0.0.0(does not exist, missingimagePrefixor should not setubi9ImageTags=false)How Has This Been Tested?
Kubernetes Checklist
User Facing Changes