Skip to content

CORE-340: Add openshift.ubi9ImageTags helm value#3753

Merged
damemi merged 3 commits into
odigos-io:mainfrom
damemi:mike/core-340-setting-the-flag-for-openshiftenabled-during-helm-install
Nov 12, 2025
Merged

CORE-340: Add openshift.ubi9ImageTags helm value#3753
damemi merged 3 commits into
odigos-io:mainfrom
damemi:mike/core-340-setting-the-flag-for-openshiftenabled-during-helm-install

Conversation

@damemi
Copy link
Copy Markdown
Member

@damemi damemi commented Nov 6, 2025

Description

This allows users to install with openshift.enabled=true using non-ubi9 images.

The expected use case is an OpenShift user who has mirrored their own images, but still needs the additional OpenShift settings (RBAC, selinux permissions, etc)

Setting openshift.ubi9ImageTags=false will not append the -ubi9 suffix onto pulled tags. This will only work if the user is not pulling from the Red Hat certified registry (which openshift.enabled=true uses by default), because we only push UBI9 images there.

So, the intended use is to combine this with imagePrefx=docker.io/.....

Example:


Install on OpenShift, using non-UBI images from my own registry:

./odigos install --set openshift.enabled=true --set imagePrefix=docker.io/mikeodigos --set openshift.ubi9ImageTags=false

Image format: docker.io/mikeodigos/odigos-odiglet:v1.x


Install on OpenShift, using UBI images from my own registry:

./odigos install --set openshift.enabled=true --set imagePrefix=docker.io/mikeodigos

Image format: docker.io/mikeodigos/odigos-odiglet-ubi9:v1.x (this is valid for OpenShift users who are mirroring certified images to their cluster


Install on OpenShift, using UBI images from Red Hat:

./odigos install --set openshift.enabled=true

Image format: registry.connect.redhat.com/odigos/odigos-collector-ubi9:v0.0.0


INVALID: Install on OpenShift, using non-UBI images from Red Hat (will not work):

./odigos install --set openshift.enabled=true --set openshift.ubi9ImageTags=false

Image format: registry.connect.redhat.com/odigos/odigos-collector:v0.0.0 (does not exist, missing imagePrefix or should not set ubi9ImageTags=false)

How Has This Been Tested?

  • Added Unit Tests
  • Updated e2e Tests
  • Manual Testing
  • Manual Load Test

Kubernetes Checklist

  • Changes how Odigos interacts with Kubernetes
  • Introduces additional calls to the API Server (potential performance impact)
  • New Query/feature supported in all the k8s versions supported by Odigos
  • Modifies Odigos manifests (addressed in both CLI and Helm)
  • Changes RBAC permissions

User Facing Changes

  • Users need to take action before upgrading
  • Automatic migration will modify existing objects (backward compatible)
  • Changes UI, CLI, or K8s Manifests aspects in a way that users need to be aware of
  • Documentation updated accordingly

@damemi
Copy link
Copy Markdown
Member Author

damemi commented Nov 6, 2025

Also fixing a "broken link" flake in the otlphttp destination

@damemi damemi requested a review from blumamir November 7, 2025 13:34
✅ Traces
✅ Metrics
Logs
Logs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me, OpsVerse logs was disabled due to the deprecation of lokiexporter from contrib

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also confused by the docs changes. This came out of just running the sync-dest-docs script, so maybe there is an issue locally for me on that

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there are more places that needs this logic change in the code but one place that comes to mind is: odigos-agents init container we add in the webhhok when the mount method is init-container.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I think that does need a similar update in code

otherwise, I think all images come from install at this point right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually don't have a RH certified odigos-agents image and the initContainer image helper never uses the -ubi9 suffix

@damemi damemi force-pushed the mike/core-340-setting-the-flag-for-openshiftenabled-during-helm-install branch from 4b9bf6a to 325ef97 Compare November 12, 2025 13:24
@damemi damemi merged commit 44634f6 into odigos-io:main Nov 12, 2025
69 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants