refactor: move init code from main to instrumentor package #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
reviewed
Feb 14, 2025
| @@ -83,5 +83,19 @@ func SetupWithManager(mgr ctrl.Manager) error { | |||
| return err | |||
| } | |||
|
|
|||
| err = builder. | |||
There was a problem hiding this comment.
this webhook is used by startlangdetection and deleteinstrumentationconfig controllers, so it can be set on the main instrumentor manager like it originally was
There was a problem hiding this comment.
Done.
Also added a comment about this, that we are planning to combine this controllers and the webhook can move into the unified controller once we do that. PTAL
RonFed
force-pushed
the
refactor_instrumentor_main
branch
from
e6fe3cb to
129b603
Compare
blumamir
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly refactor the instrumentor main function, and extracts it's code to the
instrumentorpackage.instrumentor.Newinitlizes the manager and all its controllers and webhooks.instrumentor.Runlaunches the runnables including the manager itself.The telemetry reporter was adjusted to accept a context so we can cancel it once the instrumentor shuts down and exit gracefully.