Use registry.odigos.io
for images and update default image-prefix
#2438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code to use
registry.odigos.io/*
instead of dockerhub/keyval/
. This also changes the default for theimage-prefix
setting toregistry.odigos.io
The reasoning for this is that previously, all of our images were on dockerhub under the keyval org. For example:
keyval/odigos-odiglet
This really evaluates to
docker.io/keyval/odigos-odiglet
, meaning that even though the default value for--image-prefix
is technically empty, it is actually essentially defaulting to--image-prefix=docker.io
. This is why the new default--image-prefix
is changing.In addition, with the new registry, all of our images are hosted directly under the main domain, such as
registry.odigos.io/odigos-odiglet
So, there is no need for us to add the
keyval/
prefix to our images anymore. Similarly, there is no reason for users to addkeyval/
to their own images when using their own registry. This is why we are dropping it from the default image names.These changes may be initially breaking to some users, but I think it is a lot more intuitive:
docker.io
->registry.odigos.io
keyval/odigos-<component>
->odigos-<component>