Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry.odigos.io for images and update default image-prefix #2438

Merged
merged 10 commits into from
Feb 17, 2025

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Feb 12, 2025

This updates the code to use registry.odigos.io/* instead of dockerhub/keyval/. This also changes the default for the image-prefix setting to registry.odigos.io

The reasoning for this is that previously, all of our images were on dockerhub under the keyval org. For example: keyval/odigos-odiglet

This really evaluates to docker.io/keyval/odigos-odiglet, meaning that even though the default value for --image-prefix is technically empty, it is actually essentially defaulting to --image-prefix=docker.io. This is why the new default --image-prefix is changing.

In addition, with the new registry, all of our images are hosted directly under the main domain, such as registry.odigos.io/odigos-odiglet

So, there is no need for us to add the keyval/ prefix to our images anymore. Similarly, there is no reason for users to add keyval/ to their own images when using their own registry. This is why we are dropping it from the default image names.

These changes may be initially breaking to some users, but I think it is a lot more intuitive:

  • Default prefix: docker.io->registry.odigos.io
  • Default image names keyval/odigos-<component> -> odigos-<component>

@damemi damemi changed the title (DO NOT MERGE) Use registry.odigos.io for images (DO NOT MERGE) Use registry.odigos.io for images and update default image-prefix Feb 12, 2025
@damemi damemi changed the title (DO NOT MERGE) Use registry.odigos.io for images and update default image-prefix Use registry.odigos.io for images and update default image-prefix Feb 17, 2025
@damemi damemi enabled auto-merge (squash) February 17, 2025 21:05
@damemi damemi merged commit d927f68 into odigos-io:main Feb 17, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants