Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1959]: add IBM Instana destination #2433

Merged
merged 10 commits into from
Feb 12, 2025

Conversation

BenElferink
Copy link
Contributor

This pull request introduces support for IBM Instana as a new destination in the configuration. The changes include adding configuration options, updating documentation, and integrating Instana into the existing system.

Key changes include:

Instana Configuration

  • Added Instana struct and associated methods in common/config/instana.go to handle Instana-specific configuration.
  • Introduced InstanaDestinationType in common/dests.go to identify Instana as a destination type.

Utility Functions

  • Added errorMissingKey function in common/config/utils.go to handle missing configuration keys.

Documentation Updates

  • Added documentation for configuring IBM Instana in docs/backends/instana.mdx.
  • Updated docs/adding-new-dest.mdx to reflect the new error handling and pipeline names. [1] [2] [3]
  • Included IBM Instana in the backends overview in docs/backends-overview.mdx.
  • Updated docs/mint.json to include the new Instana backend documentation.

YAML Configuration

  • Added destinations/data/instana.yaml to define the Instana destination fields and properties.

@BenElferink BenElferink enabled auto-merge (squash) February 12, 2025 10:23
Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@BenElferink BenElferink merged commit 7e20252 into odigos-io:main Feb 12, 2025
45 checks passed
@BenElferink BenElferink deleted the gen-1959 branch February 18, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants