Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to publish images to artifact registry #2422

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Feb 10, 2025

This adds a workflow to publish our components to Artifact Registry. It will currently run separate/alongside our normal release pipeline to verify that everything works before we make the switch.

Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

we also need to publish the cli image to the registry since it's being used by helm today:

repository: keyval/odigos-cli

The cli image is being built and published here:

- name: publish cli image to docker registries

Also, before we release the cli we make sure all images are published successfully here:

TAGS_JSON=$(curl -s "https://hub.docker.com/v2/repositories/${{ env.DOCKERHUB_ORG }}/$REPO/tags/")

This is so that we don't release cli and helm and then the install fails due to unpublished image. we can do something similar now or later for our private repo

${{
(matrix.service == 'collector' && 'collector') ||
'.'
}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can send here an notification to our slack release channel to notify on success/errors so we know to fix them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to spam the slack if this fails since we're not actually depending on these images yet. When we know it works, I will merge this workflow into the existing publish action that notifies slack. For now, I kept it to just what's needed to build. I'll be watching it closely anyway :)

@damemi damemi enabled auto-merge (squash) February 10, 2025 17:54
@damemi damemi merged commit 261a49d into odigos-io:main Feb 10, 2025
43 of 45 checks passed
@damemi damemi deleted the cloud-build-file branch February 10, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants