-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to publish images to artifact registry #2422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
we also need to publish the cli image to the registry since it's being used by helm today:
odigos/helm/odigos/values.yaml
Line 164 in 8dbd659
repository: keyval/odigos-cli |
The cli image is being built and published here:
odigos/.github/workflows/release.yml
Line 94 in 8dbd659
- name: publish cli image to docker registries |
Also, before we release the cli we make sure all images are published successfully here:
odigos/.github/workflows/release.yml
Line 60 in 8dbd659
TAGS_JSON=$(curl -s "https://hub.docker.com/v2/repositories/${{ env.DOCKERHUB_ORG }}/$REPO/tags/") |
This is so that we don't release cli and helm and then the install fails due to unpublished image. we can do something similar now or later for our private repo
${{ | ||
(matrix.service == 'collector' && 'collector') || | ||
'.' | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can send here an notification to our slack release channel to notify on success/errors so we know to fix them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to spam the slack if this fails since we're not actually depending on these images yet. When we know it works, I will merge this workflow into the existing publish action that notifies slack. For now, I kept it to just what's needed to build. I'll be watching it closely anyway :)
This adds a workflow to publish our components to Artifact Registry. It will currently run separate/alongside our normal release pipeline to verify that everything works before we make the switch.