Feat: UI Containers #2414
Merged
Feat: UI Containers #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonkeyval
reviewed
Feb 10, 2025
alonkeyval
reviewed
Feb 10, 2025
alonkeyval
approved these changes
Feb 10, 2025
|
|
||
| export default function Page() { | ||
| // call important hooks that should run on page-mount | ||
| useSSE(); |
There was a problem hiding this comment.
this will run on every render?
There was a problem hiding this comment.
Created Notion issue: GEN-2344
Comment on lines
66
to
74
| // configuredSources & configuredFutureApps are set in store from the previous step in onboarding flow | ||
| await persistSources(configuredSources, configuredFutureApps); | ||
| await Promise.all(configuredDestinations.map(async ({ form }) => await createDestination(form))); | ||
|
|
||
| resetState(); | ||
| router.push(ROUTES.OVERVIEW); | ||
| }; | ||
|
|
||
| const isSourcesListEmpty = () => !Object.values(configuredSources).some((sources) => !!sources.length); |
There was a problem hiding this comment.
should we maintain logic inside pages?
There was a problem hiding this comment.
Created Notion issue: GEN-2344
| left={[<OdigosLogoText key='logo' size={100} />]} | ||
| center={[ | ||
| <Text key='msg' family='secondary'> | ||
| START WITH ODIGOS |
There was a problem hiding this comment.
All the consts here can move to the odigos/ui-utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most of the UI code, and re-uses from the
@odigos/ui-containerslib.