-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a status condition to ic for instrumentation details #2408
Conversation
I'm not sure if a condition is the best approach for this. We could add a dedicated field for it in the status such as Regarding the reasons for not instrumenting, I think we could add those to the CR if and when we'll implement a finalizer for it. Right now the instrumentationConfig should not exist if we decided not to instrument. Those reasons are great for |
…ce-created-reason
…t yet instrumented
This adds a condition that describes why the workload is instrumented (which kind of source), along with it's name for better troubleshooting and traceability.
Examples:
The function in k8sutils now returns more info about the decision, which can later be used for odigos describe and possibly be also persisted with ic delete if we ever need finalizers for it.