Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI crash #2380

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Fix UI crash #2380

merged 7 commits into from
Feb 4, 2025

Conversation

BenElferink
Copy link
Contributor

  • Add app error boundary
  • Fix UI crash (conditions can be null on rare occasions)
  • Fix bad setState in toggle component

This pull request introduces an error boundary component to the frontend/webapp to handle errors gracefully and updates several dependencies. The most important changes include the addition of the AppErrorBoundary component, updates to the RootLayout to use the new error boundary, and modifications to handle nullable conditions in various types.

Error handling improvements:

Dependency updates:

  • frontend/webapp/package.json: Updated several dependencies, including @apollo/client, @odigos/ui-components, @odigos/ui-utils, and added react-error-boundary.

Handling nullable conditions:

@BenElferink BenElferink added bug Something isn't working frontend labels Feb 4, 2025
@BenElferink BenElferink enabled auto-merge (squash) February 4, 2025 12:40
@blumamir blumamir disabled auto-merge February 4, 2025 13:15
@blumamir blumamir merged commit b1b5d15 into odigos-io:main Feb 4, 2025
18 of 22 checks passed
@BenElferink BenElferink deleted the ui-filters-crash branch February 18, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants