fix: remove pod label from workload manifest #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
reviewed
Feb 4, 2025
There was a problem hiding this comment.
also for statefulset and daemonset
| if rule.Spec.OtelSdks == nil { | ||
| continue | ||
| } | ||
| // TODO: change this from otel sdks to distros and use distro name |
There was a problem hiding this comment.
why not taking the value from the rule if avaialble?
There was a problem hiding this comment.
This is missing, I still need to address this
damemi
reviewed
Feb 4, 2025
UI describe edits
BenElferink
approved these changes
Feb 5, 2025
RonFed
approved these changes
Feb 5, 2025
damemi
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.