[GEN-2309] fix: config set command #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
…o TASK-159-connect-api
blumamir
approved these changes
Feb 3, 2025
| }, | ||
| } | ||
|
|
||
| func updateConfigProperty(ctx context.Context, client *kube.Client, ns, property, value string) error { | ||
| configMapName := "odigos-config" | ||
| func setConfigProperty(config *common.OdigosConfiguration, property string, value []string) error { |
There was a problem hiding this comment.
should we err in case the property expects 1 value but the value array has more than one?
instead of ignoring it
cli/cmd/config.go
Outdated
Comment on lines
34
to
37
| ns, _ := cmd.Flags().GetString("namespace") | ||
| if ns == "" { | ||
| ns = "odigos-system" | ||
| ns = consts.DefaultOdigosNamespace | ||
| } |
There was a problem hiding this comment.
please use
ns, err := resources.GetOdigosNamespace(client, ctx)
To automatically get the namespace instead of having the user supplying it
…al/odigos into gen-2309-fix-config-set-command
…al/odigos into gen-2309-fix-config-set-command
|
@alonkeyval @blumamir do you think this could replace #2303? My intent with that was to be able to override settings like image prefix. I had also considered a new |
|
@damemi It sounds like we can use this command for the purposes you described as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
cli/cmd/config.gofile to enhance configuration management in Odigos. The changes include importing new packages, updating command arguments, and modifying the configuration update process.Imports and Dependencies:
resources,odigospro,common, andconstspackages to support new functionalities.Command Argument Handling:
Argsfor thesetConfigCmdcommand fromcobra.ExactArgs(2)tocobra.MinimumNArgs(2)to allow for multiple values.Configuration Update Process:
updateConfigPropertyfunction withsetConfigPropertyto handle a broader range of configuration properties and to increment theConfigVersion.resources.GetCurrentConfig,resources.CreateResourceManagers, andresources.ApplyResourceManagers.These changes improve the flexibility and robustness of the configuration management in Odigos.