Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2303]: fix loader for namespace-sources #2371

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

BenElferink
Copy link
Contributor

@BenElferink BenElferink commented Feb 3, 2025

This pull request includes changes to the frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx file to improve the user experience by updating the styling and handling the loading state for namespaces.

Styling improvements:

  • Changed the NoDataFoundWrapper component's margin to padding for better spacing and layout.

User experience improvements:

  • Updated the SourcesList component to display a loading spinner (FadeLoader) when namespaces are loading, instead of showing the "No sources available" message.

@BenElferink BenElferink added bug Something isn't working frontend labels Feb 3, 2025
Copy link

@BenElferink BenElferink enabled auto-merge (squash) February 3, 2025 16:33
@BenElferink BenElferink merged commit 38bdcec into odigos-io:main Feb 3, 2025
45 checks passed
@BenElferink BenElferink deleted the gen-2303 branch February 18, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants