Add docs page on Source details #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenElferink
reviewed
Jan 29, 2025
RonFed
reviewed
Jan 29, 2025
Comment on lines
100
to
101
| * When creating a Source grouping in the UI, Odigos will create a Workload Source for each Workload in the group. | ||
| * In v1.0.144+, when setting the `odigos-instrumentation` label on a workload or namespace, Odigos will automatically create a Source to migrate from the legacy label to Sources. Note that deleting the label will not remove the Source once it is automatically created. |
There was a problem hiding this comment.
Do you think this will need revisiting once we implement the Source ownership? wonder if should keep this out until we have an implementation
There was a problem hiding this comment.
I think we should say exactly what happens right now, and then yes once we change how Sources work for ownership this should be updated
damemi
force-pushed
the
source-details-docs
branch
2 times, most recently
from
7553f49 to
0fe233e
Compare
damemi
force-pushed
the
source-details-docs
branch
from
0fe233e to
a58667a
Compare
|
@BenElferink @blumamir ptal, I think this would help some of the questions we saw today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new page on some of the under-the-hood details of how sources work and how they are meant to be used