Add LICENSES folder #2253
Closed
Add LICENSES folder #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenElferink
approved these changes
Jan 20, 2025
damemi
force-pushed
the
licenses-folder
branch
from
bbb6395 to
0b7e534
Compare
damemi
force-pushed
the
licenses-folder
branch
4 times, most recently
from
eaa2513 to
1ff94fc
Compare
damemi
force-pushed
the
licenses-folder
branch
from
1ff94fc to
b9e4e6a
Compare
damemi
force-pushed
the
licenses-folder
branch
from
05e21ac to
23a2593
Compare
|
Committing these adds about 10MB to the repo -- going to generate them in the red hat image build stage instead #2252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses https://github.com/google/go-licenses to generate a LICENSES folder based on our dependencies for each distributable component (autoscaler, collector, instrumentor, odiglet, scheduler, ui). This folder is required to be in container images for Red Hat certification.
It's annoying to have to copy a LICENSE file to each module, but I couldn't find a better way to share them. We could do symlinks or something but I don't think it's that big of a deal.
For the collector, right now the LICENSES folder has to be generated on its own because of an ambiguous import upstream that breaks the generator. I think this will be resolved in the next upstream otel collector release. But again, not that big of a deal.