Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Light Mode #2228

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

UI - Light Mode #2228

wants to merge 18 commits into from

Conversation

BenElferink
Copy link
Contributor

@BenElferink BenElferink commented Jan 14, 2025

Preview: loom video 🎥


This pull request includes several changes to the frontend/webapp directory, focusing on updating the usage of themes and improving the styling of various components. The most important changes include the following:

Theme Updates:

  • Updated various icon components to use useTheme from styled-components instead of directly importing the theme. This change affects multiple files, including add-cluster-info-icon.tsx, delete-attribute-icon.tsx, pii-masking-icon.tsx, rename-attribute-icon.tsx, sampler-icon.tsx, odigos-logo-text.tsx, odigos-logo.tsx, arrow-icon.tsx, avatar-icon.tsx, check-circled-icon.tsx, check-icon.tsx, code-brackets-icon.tsx, code-icon.tsx, copy-icon.tsx, cross-circled-icon.tsx, cross-icon.tsx, edit-icon.tsx, and error-round-icon.tsx. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]

Styling Improvements:

  • Modified the RootLayout component in layout.tsx to dynamically change the background color based on the darkMode state from useDarkModeStore. [1] [2]
  • Added a transition effect to svg elements in globals.css to ensure smooth transitions.
  • Adjusted the transition properties for input:-webkit-autofill to ensure consistent styling across different states.

@BenElferink BenElferink added enhancement New feature or request frontend labels Jan 14, 2025
@BenElferink BenElferink marked this pull request as ready for review January 15, 2025 12:43
@BenElferink BenElferink changed the title UI - Light Mode (WIP) UI - Light Mode Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant