[GEN-2169]: adjust title visibility for sources in overview #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenElferink
changed the title
alonkeyval
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across different files to improve the handling of UI elements and notifications. The most important changes include adjustments to the title width in the
overview-drawer, enhancements to theuseSSEhook for better notification handling, and updates to theDataTabcomponent to manage title overflow and tooltips.UI Improvements:
frontend/webapp/containers/main/overview/overview-drawer/drawer-header/index.tsx: Reduced the maximum width of theTitlecomponent from 400px to 270px to better fit the design.frontend/webapp/reuseable-components/data-tab/index.tsx: Introduced aMAX_TITLE_WIDTHconstant and updated theTitlecomponent to use this constant. Added logic to handle title overflow by displaying a tooltip when necessary. [1] [2] [3] [4]Notification Handling:
frontend/webapp/hooks/notification/useSSE.ts: Modified theuseSSEhook to refetch sources for bothInstrumentationConfigandInstrumentationInstancenotification types, improving the handling of these notifications.Codebase Enhancements:
frontend/webapp/reuseable-components/data-tab/index.tsx: Added missing imports foruseEffectanduseRefto handle the new title overflow logic.frontend/webapp/reuseable-components/text/index.tsx: Refactored theTextcomponent to useforwardReffor better handling of refs and updated theTextPropsinterface for type consistency. [1] [2]