feat: delete instrumentation instance if exit with healthy state #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirdavid1
force-pushed
the
delete-ii-if-process-exit-gracefully
branch
from
187ffdd to
c4193ab
Compare
blumamir
approved these changes
Jan 13, 2025
RonFed
approved these changes
Jan 13, 2025
| if message.Health.Healthy { | ||
| return fmt.Errorf("agent disconnect message with healthy status") | ||
| c.logger.Info("Agent disconnected with healthy status, deleting instrumentation instance", "workloadNamespace", connectionInfo.Workload.Namespace, "workloadName", connectionInfo.Workload.Name, "workloadKind", connectionInfo.Workload.Kind) |
There was a problem hiding this comment.
This log can happen a lot for certain applications, right? (i.e python server that runs processes periodically)?
There was a problem hiding this comment.
@RonFed correct, but there is already a log for opamp connect meaning we will have logs for each process connect as well
tamirdavid1
force-pushed
the
delete-ii-if-process-exit-gracefully
branch
from
607557e to
c3fecb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.