[GEN-2208]: fix destination field handling for "multi input" #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the handling and parsing of JSON data in the dynamic fields and form data for destinations in the frontend web application. The most important changes include adding the
safeJsonParseutility function to handle JSON parsing safely and refactoring the components to use this function.Improvements to JSON parsing:
frontend/webapp/containers/main/destinations/destination-form-body/dynamic-fields/index.tsx: Added thesafeJsonParseutility function to the imports.frontend/webapp/containers/main/destinations/destination-form-body/dynamic-fields/index.tsx: Updated theInputListandKeyValueInputsListcomponents to usesafeJsonParsefor safely parsing JSON values.Refactoring:
frontend/webapp/hooks/destinations/useDestinationFormData.ts: Removed redundant parsing logic forMULTI_INPUTcomponent type, simplifying the code.frontend/webapp/hooks/destinations/useDestinationFormData.ts: Added a console log statement to debug the parsed fields in theuseDestinationFormDatafunction.