chore: create "profiles" module and migrate part of code to there #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
added a commit
that referenced
this pull request
Jan 11, 2025
We have a mix of dependencies on `k8s.io/api` modules. Some modules requires `v0.31.0` and some `v0.32.0`. This caused issues in #2187 , so want to clean it up in a seprate PR and then rebase. We need to understand why dependabot updated just some of them and not all
edeNFed
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation:
k8sutilsclicliThis PR creates a new
profilesgo module, similar to the one we currently have fordestinationsand migrate part of the code to there. It removes everything profile related fromk8sutilswhich are not a good place to store the actual profiles and maintain them in utils package that is consumed by all other modules.