[GEN-2209]: fix delete button logic in input lists #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the behavior of input components in the
frontend/webapp/reuseable-componentsdirectory. The main focus is on ensuring that the delete button functionality is consistent and that input validation is properly handled.Improvements to input validation and delete button functionality:
frontend/webapp/reuseable-components/input-list/index.tsx: Added theisEmptyutility function and modified the logic to disable the delete button when there is only one row and all inputs are empty. TheautoFocusattribute was also updated to useisEmpty. [1] [2] [3]frontend/webapp/reuseable-components/input-table/index.tsx: Included theisEmptyutility function and updated the logic to disable the delete button under similar conditions as the input list. TheautoFocusattribute was adjusted accordingly. [1] [2] [3] [4]frontend/webapp/reuseable-components/key-value-input-list/index.tsx: Integrated theisEmptyutility function and modified the delete button logic to ensure it is disabled when appropriate. TheautoFocusandhasErrorattributes were also updated to useisEmpty. [1] [2] [3] [4] [5]