New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reconcile effective collectors sizing profiles #2181

Merged

blumamir merged 2 commits into odigos-io:main from blumamir:payload-collection-sizes

Jan 11, 2025

Collaborator

blumamir commented Jan 10, 2025

This PR makes it so that we reconcile sizing profiles in schedualer into effective config, instead of modifying the config object itself in cli.

It give the following benefits:

works with helm (vs current implementation that only works with cli).
cleaner code - the code that sets values for profile is now part of the profile for easier navigation in the code base
remove complication from cli regarding handling these values

blumamir added 2 commits

January 10, 2025 23:06


          chore: use effective config to set sizing profiles

0a50829


          feat: set sizing to size_s if not set

72a38e2

blumamir changed the title ~~feat: reconcile effective collectors profiles~~ feat: reconcile effective collectors sizing profiles

edeNFed approved these changes

View reviewed changes

blumamir merged commit 0a7fb69 into odigos-io:main

31 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet