[GEN-2202] chore: remove legacy UI #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer Task 149 sources container
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
blumamir
approved these changes
Jan 8, 2025
| @@ -13,7 +13,6 @@ FROM --platform=$BUILDPLATFORM golang:1.23 AS backend | |||
| WORKDIR /app | |||
| COPY . . | |||
| COPY --from=builder /webapp/out frontend/webapp/out | |||
| COPY --from=builder /webapp/dep-out frontend/webapp/dep-out | |||
There was a problem hiding this comment.
can we also delete the files in frontend/webapp/dep-out from git?
There was a problem hiding this comment.
If we're deleting dep-out, we might as well delete endpoints.
But 1st we'd have to move these 3 folders from endpoints to services:
- sse
- actions
- collector_metrics
…gos into gen-2202-remove-legacy-ui
BenElferink
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to remove legacy UI support and clean up the codebase by eliminating unused endpoints and simplifying port forwarding logic.
Removal of legacy UI support:
cli/cmd/resources/ui.go: Removed thelegacy-uiservice port configuration.cli/cmd/ui.go: Removed thelegacyDefaultPortconstant and thelegacyflag, along with related logic in theuiCmdcommand andportForwardWithContextfunction. [1] [2] [3] [4] [5]Codebase cleanup:
frontend/endpoints/actions/addclusterinfo.go: Removed the entire file, including all related endpoint functions.frontend/endpoints/actions/deleteattribute.go: Removed the entire file, including all related endpoint functions.frontend/endpoints/actions/errorsampler.go: Removed the entire file, including all related endpoint functions.frontend/endpoints/actions/latencysampler.go: Removed the entire file, including all related endpoint functions.frontend/endpoints/actions/piimasking.go: Removed the entire file, including all related endpoint functions.frontend/endpoints/actions/probabilisticsampler.go: Removed the entire file, including all related endpoint functions.frontend/endpoints/actions/renameattribute.go: Removed the entire file, including all related endpoint functions.Dockerfile update:
frontend/Dockerfile: Removed theCOPY --from=builder /webapp/dep-out frontend/webapp/dep-outline.