Verify the language of a process before instrumenting #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our language detection is done in the container level but instrumentation is done in the process level it is possible that we'll try to instrument a process as being in certain language even though it is written in a different one - this can happen when multiple processes exist in the same container.
To handle this, the distribution matcher is updated to call the language inspector of the language written in the device - and verify the language match.
In addition, the manager is updated to call the reporter
OnInitmethod regardless of an init error. Also tracking the PID in case of an init error - this allows the reporter to clean the instrumentation instance once the PID is exiting.