-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-2170]: implement paginated sources for improved performance #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strumentationConfigs
…onboarding state management
alonkeyval
reviewed
Jan 7, 2025
alonkeyval
reviewed
Jan 7, 2025
alonkeyval
reviewed
Jan 7, 2025
alonkeyval
reviewed
Jan 7, 2025
alonkeyval
reviewed
Jan 7, 2025
alonkeyval
reviewed
Jan 7, 2025
… updating related components
alonkeyval
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the GraphQL schema and resolver logic to introduce pagination for the
sources
field in theComputePlatform
type. The primary changes involve replacing the existingK8sActualSources
field with a newPaginatedSources
type that supports pagination.Changes to the GraphQL schema:
frontend/gqlgen.yml
: Addedresolver: true
for the newsources
field.frontend/graph/schema.graphqls
: Replacedk8sActualSources
withsources
that returnsPaginatedSources
, which includesnextPage
anditems
fields. [1] [2]Changes to the resolver logic:
frontend/graph/schema.resolvers.go
: Updated the resolver for thesources
field to handle pagination usingnextPage
parameter and returnPaginatedSources
.Changes to the generated code:
frontend/graph/generated.go
: Updated complexity functions, field arguments, and resolver middleware to support the newPaginatedSources
type and handle pagination logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Changes to the model definitions:
frontend/graph/model/models_gen.go
: Added thePaginatedSources
type and updatedComputePlatform
to usePaginatedSources
for thesources
field. [1] [2]