Remove cert-manager certificate generation, use self sign instead #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cert-manager has been unreliable, often failing to generate certificates correctly or at all. This PR removes all cert-manager dependencies and switches to always self-signing certificates. As long as the CA bundle in MutatingWebhookConfiguration matches the TLS secret used by odigos-instrumentor, everything will work reliably. This change simplifies the process and ensures consistent behavior.
BenElferink
approved these changes
Jan 7, 2025
|
@edeNFed I think we should require cert-manager for OpenShift certification. The requirements for certification include generating an Operator Bundle, which needs a set of ready-to-deploy manifests. We can generate these manifests with Do you think we could make cert-manager an optional dependency? I imagine some users might want to use cert-manager anyway. |
damemi
added a commit
to damemi/odigos
that referenced
this pull request
Jan 17, 2025
damemi
added a commit
to damemi/odigos
that referenced
this pull request
Jan 27, 2025
damemi
added a commit
to damemi/odigos
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.