[GEN-2165] create "Segment" component, and replace "ToggleButtons" & "ToggleCode" #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the frontend codebase, focusing on replacing the
ToggleCodeComponentandToggleButtonscomponents with a newSegmentcomponent. The updates span across multiple files, simplifying the code and improving the user interface.Component Replacement and Refactoring:
ToggleCodeComponentand replaced it with the newSegmentcomponent indescribe-drawer.tsx,source-drawer-container/index.tsx, andaction-form-body/index.tsxto toggle between code and pretty modes. [1] [2] [3]ToggleButtonsand replaced it with theSegmentcomponent inrule-form-body/index.tsxandaction-form-body/index.tsxto toggle between active and inactive statuses. [1] [2]File and Import Cleanup:
toggle-code-componentexport fromindex.tsfiles and deleted thetoggle-code-component/index.tsxfile. [1] [2]toggle-buttonsexport fromindex.tsfiles and deleted thetoggle-buttons/index.tsxfile. [1] [2]segmentexport toreuseable-components/index.ts.New Component Addition:
Segmentcomponent inreuseable-components/segment/index.tsx, which provides a flexible and reusable segmented control for toggling between different states.