Resource Attributes - refactor and add missing attributes #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeNFed
force-pushed
the
add-missing-kube-resource-attributes
branch
from
0b04c97 to
32bcd16
Compare
RonFed
reviewed
Jan 3, 2025
edeNFed
force-pushed
the
add-missing-kube-resource-attributes
branch
from
86428fa to
c1f6c3d
Compare
edeNFed
force-pushed
the
add-missing-kube-resource-attributes
branch
from
7ab9e5d to
511aad1
Compare
edeNFed
force-pushed
the
add-missing-kube-resource-attributes
branch
from
6183e8a to
9396435
Compare
RonFed
reviewed
Jan 10, 2025
| ResourceAttributes: utils.GetResourceAttributes(kd.pw, kd.pod.Name), | ||
| InitialConfig: sdkConfig, | ||
| ServiceName: OtelServiceName, | ||
| ResourceAttributes: resourceattributes.AfterPodStart(&resourceattributes.ContainerIdentifier{ |
There was a problem hiding this comment.
I think this change will drop the deployment.name attribute we used to have - now the processor will add them. Why not add more attributes here if we can get them, instead of relying on the processor?
Comment on lines
+171
to
+184
| "extract": config.GenericMap{ | ||
| "metadata": []string{ | ||
| "k8s.deployment.name", | ||
| "k8s.statefulset.name", | ||
| "k8s.daemonset.name", | ||
| "k8s.cronjob.name", | ||
| "k8s.job.name", | ||
| "k8s.cluster.uid", | ||
| "k8s.node.name", | ||
| "container.id", | ||
| "container.image.name", | ||
| "container.image.tag", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Does this make the add cluster info action obsolete?
| semconv "go.opentelemetry.io/otel/semconv/v1.26.0" | ||
| ) | ||
|
|
||
| type Attributes []attribute.KeyValue |
There was a problem hiding this comment.
This type definition introduces a breaking change to the factory API for eBPF instrumentation.
It adds some better syntax, but I prefer to just use the Otel type. We could still have the util functions here.
Comment on lines
+10
to
+20
| Upsert modificationFunc = func(origVal string, newVal string) string { | ||
| return newVal | ||
| } | ||
|
|
||
| AppendWithSpace modificationFunc = func(origVal string, newVal string) string { | ||
| return origVal + " " + newVal | ||
| } | ||
|
|
||
| AppendWithComma modificationFunc = func(origVal string, newVal string) string { | ||
| return origVal + "," + newVal | ||
| } |
There was a problem hiding this comment.
If those are just used for testing, better to move them to the _test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR do the following changes:
k8sattributeprocessorinodigos-data-collectionto fill the rest of the needed kubernetes resource attributes