Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2111]: read & display "conditions" for actions #2072

Merged
merged 6 commits into from
Dec 25, 2024

Conversation

BenElferink
Copy link
Contributor

This pull request includes several changes to the frontend/graph and frontend/webapp directories to introduce the PipelineAction type and improve handling of conditions in the application. Below are the most important changes:

GraphQL Schema and Resolvers:

  • Added PipelineAction type to replace IcaInstanceResponse in the GraphQL schema and resolvers. This new type includes an ActionStatus field with conditions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

  • Introduced the convertConditions function in frontend/graph/conversions.go to convert conditions from the API format to the model format.

Web Application Components:

  • Updated the ActionDrawer component to display ConditionDetails using the new PipelineAction type. [1] [2] [3]

  • Modified the SourceDrawer component to handle conditions more robustly and display them using ConditionDetails. [1] [2]

GraphQL Queries:

  • Updated the GET_COMPUTE_PLATFORM query to include the new PipelineAction type and its status field with conditions. [1] [2]

Type Definitions:

  • Updated type definitions to include the new PipelineAction and Condition types, ensuring proper handling of conditions in the application state. [1] [2] [3]

Copy link

Add Conditions to action

@BenElferink BenElferink merged commit b8956fe into odigos-io:main Dec 25, 2024
30 of 31 checks passed
@BenElferink BenElferink deleted the gen-2111 branch December 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants