[GEN-2112]: update RBAC permissions for Collector #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nhance permissions
|
@blumamir this PR is now ready for review 👍 |
blumamir
reviewed
Dec 25, 2024
blumamir
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
Makefile,README.md, and various Go files related to RBAC roles and permissions. The most important changes involve adding comments for clarity, updating thedeploytarget in theMakefile, and documenting RBAC permissions for different components.Updates to
Makefile:deploytarget to ensure all components are deployed sequentially usingmakecommands.Documentation Improvements:
cli/cmd/resources/README.mdto track RBAC permissions requested by different components, organized byAPIGroups,Resources,Verbs, and theComponentrequesting them.Codebase Simplification:
cli/cmd/resources/autoscaler.goto explain the purpose of eachPolicyRulein theNewAutoscalerRolefunction.cli/cmd/resources/datacollection.goto clarify the purpose of eachPolicyRulein theNewDataCollectionClusterRolefunction.cli/cmd/resources/odiglet.goto describe the purpose of eachPolicyRulein theNewOdigletRolefunction.