[GEN-2080]: fix useConnectDestinationForm to support additional component properties for checkboxes #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent properties for checkboxes
…rties and enhancing initial value management
…dynamic initial values
…nitialValue' for better state management
alonkeyval
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on replacing the
initialValueprop with thevalueprop for theCheckboxcomponent across various parts of the codebase. This change aims to standardize the usage of theCheckboxcomponent and ensure consistency in its implementation.Key changes include:
Checkbox Component Update:
frontend/webapp/reuseable-components/checkbox/index.tsx: ReplacedinitialValueprop withvalueprop in theCheckboxcomponent. Updated the state management and useEffect hook accordingly. [1] [2]Usage in Forms and Fields:
frontend/webapp/containers/main/actions/action-form-body/custom-fields/pii-masking.tsx: UpdatedCheckboxcomponent to usevalueinstead ofinitialValue.frontend/webapp/containers/main/destinations/destination-form-body/dynamic-fields/index.tsx: UpdatedCheckboxcomponent to usevalueinstead ofinitialValue.frontend/webapp/containers/main/instrumentation-rules/rule-form-body/custom-fields/payload-collection.tsx: UpdatedCheckboxcomponent to usevalueinstead ofinitialValue.Usage in Source Selection:
frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/source-controls/index.tsx: UpdatedCheckboxcomponent to usevalueinstead ofinitialValue.frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx: UpdatedCheckboxcomponent to usevalueinstead ofinitialValue. [1] [2]Other Updates:
frontend/webapp/hooks/destinations/useConnectDestinationForm.ts: Refactored thebuildFormDynamicFieldsfunction to use thevalueprop for various input types includingCHECKBOX.frontend/webapp/reuseable-components/dropdown/index.tsx: UpdatedCheckboxcomponent to usevalueinstead ofinitialValuein the dropdown list item.These changes ensure that the
Checkboxcomponent is consistently using thevalueprop, which improves the readability and maintainability of the codebase.