Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2041]: fix auto-fill indicator for destinations #2018

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

BenElferink
Copy link
Contributor

This pull request includes several updates to the frontend/webapp/containers/main/destinations directory, focusing on enhancing the DestinationFormBody component and improving the export structure of the DestinationsList component. The most important changes include adding new hooks and logic to handle auto-filling of dynamic fields, modifying the component structure for consistency, and updating export statements.

Enhancements to DestinationFormBody component:

  • Added useEffect and useRef hooks to handle the auto-filling check for dynamic fields and set the autoFilled state accordingly. [1] [2]
  • Modified the DestinationFormBody component to be a functional component using arrow function syntax for consistency. [1] [2]
  • Updated the rendering logic to display a notification note when the connection details are auto-filled.

Improvements to DestinationsList component:

  • Changed the DestinationsList component to be exported directly instead of using a separate export statement. [1] [2]

Copy link

@BenElferink BenElferink merged commit 0a568c2 into odigos-io:main Dec 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants