feat: configurable mock destination for pipeline testing #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirdavid1
approved these changes
Dec 16, 2024
|
|
||
| func NewMockDestinationExporter(config *Config, | ||
| params exporter.Settings) (*MockDestinationExporter, error) { | ||
|
|
There was a problem hiding this comment.
nit: maybe worth to add small config validation ?
ResponseDuration > 0
1 > RejectFraction > 0
There was a problem hiding this comment.
added in config.go under Validate function
edeNFed
reviewed
Dec 16, 2024
|
|
||
| func (e *MockDestinationExporter) mockExport(context.Context) error { | ||
| // not taking care of ctx cancel and shutdown as this is a dummy exporter and not used in production | ||
| <-time.After(e.config.ResponseDuration) |
There was a problem hiding this comment.
nit: I think time.Sleep is better as time.After create goroutine every time it is called so this has the potential to blow up CPU according to the number of parallel invocation to this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new exporter mocks a destination, and allows one to simulate various back-pressure scenarios, like long time to get a response for the export, and simulating some export requests being rejected.
It is useful for pipeline development and testing