feat: inject OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES via webhook #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we remove |
If we remove the processor, then after the first upgrade, there will still be pods that started without the webhook and if the processor is not there, the service name will show up as UUID. I suggest to keep it around for some-time until we fill comfortable that everyone has already upgraded, and then remove the processor |
blumamir
changed the title
RonFed
reviewed
Dec 16, 2024
| containerutils "github.com/odigos-io/odigos/k8sutils/pkg/container" | ||
| "github.com/odigos-io/odigos/k8sutils/pkg/workload" | ||
| "go.opentelemetry.io/otel/attribute" | ||
| semconv "go.opentelemetry.io/otel/semconv/v1.4.0" |
There was a problem hiding this comment.
I think we should use a more recent semconv
There was a problem hiding this comment.
good catch.
updated t0 1.26.0 which is what we use in other places in the codebase
RonFed
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dotnet and OSS java which currently relies on the resource to inject the device id in odiglet, and then resolves it from kublet to the desired service name