-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-2031]: add 'replicasets' resource to ClusterRole permissions #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[GEN-2001]: fix sources drawer header icon
[GEN-1723]: fix and add skeleton loaders
alonkeyval
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a variety of changes across multiple files to refine the user interface, enhance functionality, and clean up the codebase. The most important changes include adding new resources to the
NewUIClusterRole
, updating background colors in various components, removing unused imports, and modifying the logic for building nodes in the overview data flow.UI and Styling Updates:
frontend/webapp/components/main/header/index.tsx
: Updated the background color of the header to usedark_grey
instead ofdarker_grey
.frontend/webapp/components/setup/header/index.tsx
: Updated the background color of the setup header to usedark_grey
instead ofdarker_grey
.Code Cleanup:
frontend/webapp/containers/main/actions/action-drawer/index.tsx
: Removed and re-added the import ofACTION
,DATA_CARDS
, andgetActionIcon
to clean up the import statements.frontend/webapp/containers/main/destinations/add-destination/configured-destinations-list/index.tsx
: Removed the unusedText
import fromreuseable-components
.Node Building Enhancements:
frontend/webapp/containers/main/overview/overview-data-flow/build-action-nodes.ts
: Added anallowBuild
parameter to conditionally build action nodes or skeletons based on the parameter value. [1] [2] [3] [4]frontend/webapp/containers/main/overview/overview-data-flow/build-destination-nodes.ts
: Added anallowBuild
parameter to conditionally build destination nodes or skeletons based on the parameter value. [1] [2] [3] [4]frontend/webapp/containers/main/overview/overview-data-flow/build-rule-nodes.ts
: Added anallowBuild
parameter to conditionally build rule nodes or skeletons based on the parameter value. [1] [2] [3] [4]frontend/webapp/containers/main/overview/overview-data-flow/build-source-nodes.ts
: Added anallowBuild
parameter to conditionally build source nodes or skeletons based on the parameter value. [1] [2]Resource Addition:
cli/cmd/resources/ui.go
: Addedreplicasets
to the list of resources in theNewUIClusterRole
function.This PR also fixes the following production error: