Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2031]: add 'replicasets' resource to ClusterRole permissions #2006

Merged
merged 34 commits into from
Dec 16, 2024

Conversation

BenElferink
Copy link
Contributor

@BenElferink BenElferink commented Dec 15, 2024

This pull request includes a variety of changes across multiple files to refine the user interface, enhance functionality, and clean up the codebase. The most important changes include adding new resources to the NewUIClusterRole, updating background colors in various components, removing unused imports, and modifying the logic for building nodes in the overview data flow.

UI and Styling Updates:

Code Cleanup:

Node Building Enhancements:

Resource Addition:


This PR also fixes the following production error:

{
    "errors": [
        {
            "message": "error listing replicasets: replicasets.apps is forbidden: User \"system:serviceaccount:odigos-system:odigos-ui\" cannot list resource \"replicasets\" in API group \"apps\" in the namespace \"default\"",
            "path": [
                "describeSource"
            ]
        }
    ],
    "data": null
}

@BenElferink BenElferink removed the request for review from blumamir December 16, 2024 08:43
@BenElferink BenElferink enabled auto-merge (squash) December 16, 2024 09:56
@alonkeyval alonkeyval disabled auto-merge December 16, 2024 10:28
@alonkeyval alonkeyval merged commit 5c4ab5b into odigos-io:main Dec 16, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants