chore: have crds in helm chart instead of copying #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeNFed
approved these changes
Dec 13, 2024
RonFed
requested changes
Dec 13, 2024
RonFed
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The odigos CRD yamls are currently generated in the api module. Whenever the helm chart should be used for development, we needed to run
cp -r ./api/config/crd/bases/* ./helm/odigos/templates/crds/to have the helm repo working.I think it's nicer to have all the files right in the helm. template, and remove the need to
cpin release and deplpoyment. Added a check in CI to make sure the files are aligned