Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nop destination and cleanup deprecated components #1984

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

blumamir
Copy link
Collaborator

@blumamir blumamir commented Dec 13, 2024

This PR:

  • removes the deprecated and unused logging exporter, which is replaced with the debug exporter which we do use.
  • removed the deprecated ballast extension which we don't use and is deprecated in favor of GOMEMLIMIT which we do use.
  • adds the nop exporter which is useful for development and testing (for example - load scenarios)
  • adds documentation in CONTRIBUTING.md regarding how to use the debug and nop destination for development.

Copy link
Contributor

@edeNFed edeNFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea!
nit: I think adding it as a target in Makefile will be more convenient than documenting in markdown file

@blumamir
Copy link
Collaborator Author

Cool idea! nit: I think adding it as a target in Makefile will be more convenient than documenting in markdown file

good idea. Added and updated the markdown

@blumamir blumamir merged commit 0e01004 into odigos-io:main Dec 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants