Generalize instrumentation manager #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
commented
Dec 13, 2024
blumamir
approved these changes
Dec 15, 2024
instrumentation/manager.go
Outdated
| // The manager will apply the configuration to all instrumentations that match the config group. | ||
| type ConfigUpdate[configGroup ConfigGroup] map[configGroup]Config | ||
|
|
||
| type instrumentationDetails[details Details, configGroup ConfigGroup] struct { |
There was a problem hiding this comment.
Since we already have Details, and now instrumentationDetails with a property details inside it, can we have better names so it's less confusing?
This creates code like details.details
There was a problem hiding this comment.
Renamed Details to ProcessGroup and added comments explaining the meaning behind it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #1776:
odiglet/pkg/ebpf