[GEN-1710]: add scroll to overview sources #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonkeyval
reviewed
Dec 12, 2024
frontend/webapp/reuseable-components/nodes-data-flow/nodes/scroll-node.tsx
Show resolved
Hide resolved
alonkeyval
reviewed
Dec 12, 2024
| @@ -86,7 +84,7 @@ const HeaderNode: React.FC<Props> = ({ nodeWidth, data }) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <Container $nodeWidth={nodeWidth + extraWidth}> | |||
| <Container $nodeWidth={nodeWidth} className='nowheel nodrag'> | |||
There was a problem hiding this comment.
what is the use of this?
There was a problem hiding this comment.
This are classes provided by React-Flow, which prevent their internal drag/scroll behavior, applying them allows us to control scroll etc.
alonkeyval
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the frontend web application, primarily focused on refactoring components and adding new functionalities to the overview data flow. The key changes include converting components to named exports, building nodes for various entity types, and constructing edges for data flow visualization.
Component Refactoring:
frontend/webapp/containers/main/overview/multi-source-control/index.tsx: ConvertedMultiSourceControlto a named export. [1] [2]frontend/webapp/containers/main/overview/overview-actions-menu/index.tsx: ConvertedOverviewActionsMenuto a named export. [1] [2]Node Building for Overview Data Flow:
frontend/webapp/containers/main/overview/overview-data-flow/build-action-nodes.ts: Added functionality to build nodes for actions in the overview data flow.frontend/webapp/containers/main/overview/overview-data-flow/build-destination-nodes.ts: Added functionality to build nodes for destinations in the overview data flow.frontend/webapp/containers/main/overview/overview-data-flow/build-rule-nodes.ts: Added functionality to build nodes for instrumentation rules in the overview data flow.frontend/webapp/containers/main/overview/overview-data-flow/build-source-nodes.ts: Added functionality to build nodes for sources in the overview data flow.Edge Building for Data Flow:
frontend/webapp/containers/main/overview/overview-data-flow/build-edges.ts: Added functionality to build edges for connecting nodes in the overview data flow.Utility Functions:
frontend/webapp/containers/main/overview/overview-data-flow/get-entity-counts.ts: Added a utility function to get entity counts for different types in the overview data flow.frontend/webapp/containers/main/overview/overview-data-flow/get-node-positions.ts: Added a utility function to calculate node positions based on container width.