-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add healthy condition to source #1976
Merged
alonkeyval
merged 231 commits into
odigos-io:main
from
alonkeyval:add-healthy-condition
Dec 11, 2024
Merged
Add healthy condition to source #1976
alonkeyval
merged 231 commits into
odigos-io:main
from
alonkeyval:add-healthy-condition
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer Task 149 sources container
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
BenElferink
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
frontend
package, focusing on refactoring functions, improving code readability, and enhancing the condition handling for instrumented applications.Refactoring and Code Simplification:
instrumentedApplicationToActualSource
function infrontend/graph/conversions.go
to simplify the code.AutoInstrumentedDecision
field to be an empty string in theinstrumentedApplicationToActualSource
function infrontend/graph/conversions.go
.Condition Handling Enhancements:
AddHealthyInstrumentationInstancesCondition
in theK8sActualSources
resolver infrontend/graph/schema.resolvers.go
to ensure healthy instrumentation instances are tracked.GetActualSource
function infrontend/services/sources.go
to useAddHealthyInstrumentationInstancesCondition
with anil
source parameter.addHealthyInstrumentationInstancesCondition
function (renamed toAddHealthyInstrumentationInstancesCondition
) infrontend/services/sources.go
to usemodel.ConditionStatusTrue
andmodel.ConditionStatusFalse
instead ofmetav1.ConditionTrue
andmetav1.ConditionFalse
, respectively. Also, added formatted message and transition time handling. [1] [2]Utility Functions:
Metav1TimeToString
infrontend/services/utils.go
to convertmetav1.Time
to a string formatted in RFC3339.Minor Code Improvements:
Actions
resolver infrontend/graph/schema.resolvers.go
to improve code readability.time
package import infrontend/services/utils.go
for date and time formatting.