Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1978]: improve UX for end-of-onboarding #1974

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

BenElferink
Copy link
Contributor

This pull request to frontend/webapp/containers/main/destinations/add-destination/index.tsx includes changes to improve the user experience by addressing loading states and preventing double-click issues. The most important changes include adding a loading spinner, modifying button states, and adjusting modal behavior.

Loading state improvements:

  • Added FadeLoader and CenterThis to display a loading spinner during asynchronous operations.
  • Introduced isLoading state to manage and display loading status, replacing the previous sourcesLoading and destinationsLoading states. [1] [2]

Button and modal behavior adjustments:

  • Updated button disabled property to use isLoading state, preventing user interactions during loading. [1] [2]
  • Modified modal visibility to depend on isLoading state, ensuring it does not open during loading.

Copy link

@BenElferink BenElferink enabled auto-merge (squash) December 11, 2024 11:34
@BenElferink BenElferink merged commit 5919acb into odigos-io:main Dec 11, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants