[GEN-1911]: add CRUD E2E tests for UI actions #1942

BenElferink · 2024-12-08T15:13:26Z

This pull request includes several changes to the frontend web application, primarily focusing on adding unique identifiers to various elements and improving Cypress tests. The most important changes include adding id attributes to key elements, enhancing the Cypress tests for better reliability, and adding new tests for CRUD operations on a specific resource.

Adding `id` attributes to elements:

frontend/webapp/components/overview/add-entity/index.tsx: Added id attributes to StyledButton and DropdownItem elements to improve element selection.
frontend/webapp/containers/main/overview/overview-drawer/drawer-footer/index.tsx: Added id attributes to FooterButton elements for save, cancel, and delete actions.
frontend/webapp/containers/main/overview/overview-drawer/drawer-header/index.tsx: Added id attributes to Input, EditButton, and CloseButton elements.
frontend/webapp/reuseable-components/auto-complete-input/index.tsx: Added id attributes to OptionItemContainer elements.
frontend/webapp/reuseable-components/drawer/index.tsx: Added id attribute to Transition element.
frontend/webapp/reuseable-components/modal/index.tsx: Added id attribute to Transition element, including dynamic titles.
frontend/webapp/reuseable-components/modal/warning-modal/index.tsx: Added id attributes to FooterButton elements for approve and deny actions.

Enhancing Cypress tests:

frontend/webapp/cypress/e2e/02-onboarding.cy.ts: Refactored tests to use beforeEach for intercepting GraphQL requests and improved the structure of the tests. [1] [2]

Adding new Cypress tests for CRUD operations:

frontend/webapp/cypress/e2e/05-actions.cy.ts: Added comprehensive tests for creating, updating, and deleting a Custom Resource Definition (CRD) in the cluster.

These changes aim to enhance the testability and reliability of the frontend components and ensure the robustness of the application through improved end-to-end testing.

merge main

This pull request includes several changes to improve the handling of action types in the `CreateAction` and `UpdateAction` resolvers, as well as the addition of a new update function for `AddClusterInfo` actions. The most important changes involve refactoring action type strings into constants and implementing the `UpdateAddClusterInfo` function. ### Refactoring action types: * [`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L560-R560): Replaced hardcoded action type strings with constants from `actionservices` for better maintainability. [[1]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L560-R560) [[2]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L569-R569) ### New update functionality: * [`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L582-R599): Implemented the `UpdateAction` resolver to handle updating `AddClusterInfo` actions. * [`frontend/services/actions/addclusterinfo.go`](diffhunk://#diff-c2da2861415e61f772e3b44d22810aa34b4eba6070f744709c4b1b6b919a3f09L70-R137): Added the `UpdateAddClusterInfo` function to update existing `AddClusterInfo` actions in Kubernetes. ### Constants definition: * [`frontend/services/actions/constants.go`](diffhunk://#diff-377602090c56364ea3a4d6cdadda1ad9b1c6ba9e122f882e5a1f640b1e62acf8R1-R7): Added constants for action types `ActionTypeAddClusterInfo` and `ActionTypeDeleteAttribute`.

…-1511-new-ui

…rch bar

This pull request introduces changes to the `DeleteAction` functionality in the `frontend/graph` package, adding support for an `actionType` parameter. This enhancement allows for more specific handling of different action types during deletion. Key changes include: ### GraphQL Schema and Resolvers * [`frontend/graph/schema.graphqls`](diffhunk://#diff-bc07b91dedd1782d9ddbbb6374ad97c7604f9a267de5174645723d863c732f80L314-R314): Updated the `deleteAction` mutation to include an `actionType` parameter. * [`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L603-R620): Modified the `DeleteAction` resolver to handle different action types based on the `actionType` parameter. ### Generated Code * [`frontend/graph/generated.go`](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L200-R200): Updated the `DeleteAction` method signatures and complexity calculations to include the `actionType` parameter. [[1]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L200-R200) [[2]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L266-R266) [[3]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L911-R911) [[4]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2R1342-R1350) [[5]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L5793-R5802) ### Action Services * [`frontend/services/actions/addclusterinfo.go`](diffhunk://#diff-c2da2861415e61f772e3b44d22810aa34b4eba6070f744709c4b1b6b919a3f09R148-R162): Added the `DeleteAddClusterInfo` function to handle the deletion of `AddClusterInfo` actions. * [`frontend/services/actions/addclusterinfo.go`](diffhunk://#diff-c2da2861415e61f772e3b44d22810aa34b4eba6070f744709c4b1b6b919a3f09R13): Imported `apierrors` for error handling in the new deletion function.

PR comments

…ify-for-graphql

[GEN-1515]: fix stringify for graphql (odigos-io#1615)

This pull request introduces a new `ProbabilisticSamplerAction` to the codebase, along with the necessary updates to support its creation, update, and deletion. The key changes include adding the new action type, updating the GraphQL schema, and implementing the corresponding service functions. ### Addition of `ProbabilisticSamplerAction`: * [`frontend/graph/model/models_gen.go`](diffhunk://#diff-642ccd7ed71fdfa394bd7f7fd99c9c33e20ff18c876a91cb989d379a44390469R311-R337): Added the `ProbabilisticSamplerAction` struct and its methods to the model. * [`frontend/graph/schema.graphqls`](diffhunk://#diff-bc07b91dedd1782d9ddbbb6374ad97c7604f9a267de5174645723d863c732f80R309-R318): Updated the GraphQL schema to include the `ProbabilisticSamplerAction` type. ### Resolver Updates: * [`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L568-R571): Updated the `CreateAction`, `UpdateAction`, and `DeleteAction` resolvers to handle the new `ProbabilisticSamplerAction` type. [[1]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L568-R571) [[2]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L586-R591) [[3]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L617-R630) ### Constants Update: * [`frontend/services/actions/constants.go`](diffhunk://#diff-377602090c56364ea3a4d6cdadda1ad9b1c6ba9e122f882e5a1f640b1e62acf8L8-R9): Added `ActionTypeProbabilisticSampler` and corrected the naming of `ActionTypeLatencySampler`. ### Service Implementation: * [`frontend/services/actions/probabilisticsampler.go`](diffhunk://#diff-2f6dc14f04b67e0a11a5b999216a0e08f575927294c5033187b84f1179fb5624R1-R139): Implemented the service functions `CreateProbabilisticSampler`, `UpdateProbabilisticSampler`, and `DeleteProbabilisticSampler` to manage `ProbabilisticSamplerAction` in Kubernetes.

notion-workspace · 2024-12-08T15:13:34Z

Cypress write tests - actions CRUD

frontend/webapp/components/overview/add-entity/index.tsx

frontend/webapp/cypress/e2e/02-onboarding.cy.ts

alonkeyval · 2024-12-09T08:23:32Z

frontend/webapp/cypress/e2e/05-actions.cy.ts

+// If you have to run tests locally, make sure to clean up the cluster before running the tests.
+
+describe('Actions CRUD', () => {
+  const namespace = 'odigos-system';


this can be reuse from a common file to other tests

Suggested change

const namespace = 'odigos-system';

const namespace = 'odigos-system';

alonkeyval · 2024-12-09T08:52:31Z

frontend/webapp/cypress/e2e/05-actions.cy.ts

+      cy.get('[data-id=add-entity]').click();
+      cy.get('[data-id=add-action]').click();
+      cy.get('[data-id=modal-Add-Action]').should('exist');
+      cy.get('[data-id=modal-Add-Action]').find('input').should('have.attr', 'placeholder', 'Type to search...').click();


this can also be from consts -> SELECTORS

alonkeyval · 2024-12-09T08:52:59Z

frontend/webapp/cypress/e2e/05-actions.cy.ts

+  it('Should create a CRD in the cluster', () => {
+    cy.visit(ROUTES.OVERVIEW);
+
+    cy.exec(`kubectl get ${crdName} -n ${namespace} | awk 'NR>1 {print $1}'`).then((crdListBefore) => {


dup function ->

const getCRDList = () =>
cy.exec(kubectl get ${crdName} -n ${namespace} | awk 'NR>1 {print $1}');

BenElferink and others added 30 commits October 20, 2024 05:28

Merge pull request #1 from odigos-io/main

c25c631

merge main

Refactor old ui to new product design (odigos-io#1605)

12046ba

Merge remote-tracking branch 'odigos/new-ui' into gen-1511-new-ui

6037f4c

[GEN-1539] Refactor action api to gql (odigos-io#1606)

62934de

Merge branch 'new-ui' of https://github.com/odigos-io/odigos into gen…

02682f9

…-1511-new-ui

feat(frontend): added actions form, and fixed bugs: empty inputs, sea…

522e782

…rch bar

Lint rules (odigos-io#1610)

9dbdc21

fix: KeyValueInputsList would not always call onChange

a55f35b

feat: custom fields with state management

619bb6d

fix: semicolon

389fc46

fix: docs link

2487549

fix: frament & imports

9e5224b

fix: MONITORING_OPTIONS from global consts

e4a8350

fix: use const, not string

a908130

Merge pull request #2 from BenElferink/gen-1515-dynamic-action-form

38e862f

PR comments

fix: dynamic signals for actions

31f1db3

fix: drawer & modal widths

bc3bad3

[GEN-1546] Add delete attr new api (odigos-io#1612)

f1ac07b

[GEN-1546] Add pii masking new api (odigos-io#1613)

254427a

[GEN-1513]: actions modal form (odigos-io#1608)

c769731

fix: stringify for graphql

89a6594

Merge remote-tracking branch 'odigos/new-ui' into gen-1515-fix-string…

9d260f4

…ify-for-graphql

[GEN-1515]: fix stringify for graphql (odigos-io#1615)

19eb1fe

Merge branch 'main' into new-ui

446c37a

Merge pull request #4 from odigos-io/new-ui

f97a5a1

[GEN-1515]: fix stringify for graphql (odigos-io#1615)

[GEN-1547] Add error sampler api (odigos-io#1629)

944480f

[GEN-1555] Add new latency sampler api (odigos-io#1630)

2637c1e

BenElferink added 17 commits December 1, 2024 14:16

Merge branch 'main' of https://github.com/odigos-io/odigos

92b7e1a

Merge branch 'main' of https://github.com/odigos-io/odigos

cae41ca

Merge branch 'main' of https://github.com/odigos-io/odigos

dba7dac

Merge branch 'main' of https://github.com/odigos-io/odigos

cc06232

Merge branch 'main' of https://github.com/odigos-io/odigos

2fc5b41

Merge branch 'main' of https://github.com/odigos-io/odigos

2c47abd

Merge branch 'main' of https://github.com/odigos-io/odigos

880204f

Merge branch 'main' of https://github.com/odigos-io/odigos

167b9ee

Merge branch 'main' of https://github.com/odigos-io/odigos

04ff3f7

Merge branch 'main' of https://github.com/odigos-io/odigos

c057945

Merge branch 'main' of https://github.com/odigos-io/odigos

f88150d

Merge branch 'main' of https://github.com/odigos-io/odigos

5ee9f3c

Merge branch 'main' of https://github.com/odigos-io/odigos

e3da9ab

fix: code review from GEN-1927

9926caa

feat: add IDs to relevant elements

059534e

feat: add create & update tests for actions

c265c6d

feat: add delete to tests for actions

4a7d0fb

BenElferink requested a review from alonkeyval December 8, 2024 15:13

BenElferink added 2 commits December 8, 2024 17:29

Merge branch 'main' into gen-1911

8c419f7

Merge branch 'main' into gen-1911

9c762a5

alonkeyval reviewed Dec 9, 2024

View reviewed changes

frontend/webapp/components/overview/add-entity/index.tsx Outdated Show resolved Hide resolved

alonkeyval reviewed Dec 9, 2024

View reviewed changes

frontend/webapp/cypress/e2e/02-onboarding.cy.ts Show resolved Hide resolved

alonkeyval reviewed Dec 9, 2024

View reviewed changes

fix: code review

12ff4ca

alonkeyval reviewed Dec 9, 2024

View reviewed changes

alonkeyval approved these changes Dec 9, 2024

View reviewed changes

BenElferink enabled auto-merge (squash) December 9, 2024 09:04

BenElferink merged commit f636461 into odigos-io:main Dec 9, 2024
31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GEN-1911]: add CRUD E2E tests for UI actions #1942

[GEN-1911]: add CRUD E2E tests for UI actions #1942

BenElferink commented Dec 8, 2024 •

edited

Loading

notion-workspace bot commented Dec 8, 2024

alonkeyval Dec 9, 2024

alonkeyval Dec 9, 2024

alonkeyval Dec 9, 2024

	const namespace = 'odigos-system';
	const namespace = 'odigos-system';

[GEN-1911]: add CRUD E2E tests for UI actions #1942

[GEN-1911]: add CRUD E2E tests for UI actions #1942

Conversation

BenElferink commented Dec 8, 2024 • edited Loading

Adding id attributes to elements:

Enhancing Cypress tests:

Adding new Cypress tests for CRUD operations:

notion-workspace bot commented Dec 8, 2024

alonkeyval Dec 9, 2024

Choose a reason for hiding this comment

alonkeyval Dec 9, 2024

Choose a reason for hiding this comment

alonkeyval Dec 9, 2024

Choose a reason for hiding this comment

BenElferink commented Dec 8, 2024 •

edited

Loading

Adding `id` attributes to elements: