[GEN-1927]: Cypress test for onboarding-flow (#1930) #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenElferink
requested review from
alonkeyval,
blumamir,
RonFed and
tamirdavid1
alonkeyval
reviewed
Dec 8, 2024
alonkeyval
reviewed
Dec 8, 2024
alonkeyval
reviewed
Dec 8, 2024
alonkeyval
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving the frontend codebase and updating the Cypress end-to-end testing configuration. The most important changes include adding unique IDs to various components, updating Cypress configuration and tests, and removing an outdated script.
Improvements to frontend components:
frontend/webapp/containers/main/destinations/destination-modal/choose-destination-body/destinations-list/destination-list-item/index.tsx: Added unique IDs toListItemcomponents for better identification.frontend/webapp/containers/main/destinations/destination-modal/choose-destination-body/destinations-list/index.tsx: Updated the key forDestinationListItemto usecategoryItem.typeinstead ofcategoryItem.displayName.frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx: Added unique IDs toGroupcomponents for better identification.frontend/webapp/reuseable-components/no-data-found/index.tsx: Added an ID to theContainercomponent for better identification.Updates to Cypress configuration and tests:
frontend/webapp/cypress.config.ts: Set thebaseUrlto use a variable for easier configuration.frontend/webapp/cypress/e2e/connection.cy.ts: Added a new test to verify the frontend and backend connections using GraphQL.frontend/webapp/cypress/e2e/onboarding.cy.ts: Updated onboarding tests to include checks for the existence of a "default" namespace and the "Jaeger" destination.Removal of outdated script:
tests/common/odigos_ui.sh: Removed the old script for managing the Odigos UI.Updates to package scripts:
frontend/webapp/package.json: Updated Cypress-related scripts and removed unnecessary build scripts. [1] [2]Changes to end-to-end test configuration:
tests/e2e/ui/chainsaw-test.yaml: Updated the test configuration to use the Odigos CLI for installing and starting the UI, and to run Cypress tests.