Refactor Odiglet main function #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
approved these changes
Nov 28, 2024
|
|
||
| <-ctx.Done() | ||
| for _, director := range ebpfDirectors { | ||
| func (o *odiglet) run() { |
There was a problem hiding this comment.
I think it's a bit non-conventional to have the ctx as property.
Consider sending it to the run function
There was a problem hiding this comment.
Right, currently I keep it that way since we have the initEbpf part which gets a context, but that will be removed soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the top-level initialization of Odiglet:
newOdilgetandrunfunctions. The first initializes all the different components, the second launches them, and handles closing them all gracefully on shutdown.OpAmp,runtime-detector,pprofserver and kube manager.