UI bugs party #1873
Merged
UI bugs party #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the frontend web application, focusing on adding new components, refactoring existing ones, and updating styles. The most important changes include the addition of new dropdown components, updates to modals and notifications, and various refactoring tasks to improve code readability and maintainability.
New Components and Features:
LanguageDropdowncomponent to the dropdowns directory. (frontend/webapp/components/common/dropdowns/language-dropdown/index.tsx)LanguageDropdownfrom the dropdowns index. (frontend/webapp/components/common/dropdowns/index.ts)Refactoring and Code Simplification:
build-card-from-action-spec.tstobuild-card.tsand updated its usage. (frontend/webapp/containers/main/actions/action-drawer/build-card.ts,frontend/webapp/containers/main/actions/action-drawer/index.tsx) [1] [2]AllDrawersandAllModalscomponents from containers to components directory and updated imports accordingly. (frontend/webapp/components/overview/all-drawers/index.tsx,frontend/webapp/components/overview/all-modals/index.tsx) [1] [2]Style Updates:
HeaderContainerin both main and setup headers to usedarker_grey. (frontend/webapp/components/main/header/index.tsx,frontend/webapp/components/setup/header/index.tsx) [1] [2]Modals and Notifications:
CancelWarningandDeleteWarningmodal button texts to be more descriptive. (frontend/webapp/components/modals/cancel-warning/index.tsx,frontend/webapp/components/modals/delete-warning/index.tsx) [1] [2]ToastListcomponent and updated its export method. (frontend/webapp/components/notification/toast-list.tsx,frontend/webapp/components/notification/index.ts) [1] [2]Utility and Hook Updates:
BACKEND_BOOLEANutility to theErrorDropdowncomponent for better readability and consistency. (frontend/webapp/components/common/dropdowns/error-dropdown/index.tsx) [1] [2]These changes collectively improve the structure, readability, and functionality of the frontend web application.