Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta UI bugs party #1807

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Beta UI bugs party #1807

merged 9 commits into from
Nov 20, 2024

Conversation

BenElferink
Copy link
Contributor

@BenElferink BenElferink commented Nov 20, 2024 •
edited
Loading

This pull request includes several changes to improve the functionality and user experience of the SourcesList component in the frontend/webapp directory, as well as updates to the 404 error page and some JavaScript chunks. The most important changes include adding a new prop to the SourcesList component, modifying filter logic, updating checkbox behavior, and correcting pluralization in text.

Changes to SourcesList component:

  • Added selectAllForNamespace prop to SourcesList component to handle the selection of all sources within a namespace.
  • Modified filter logic to always include namespaces that match the search text, regardless of the showSelectedOnly filter.
  • Updated checkbox behavior to disable it when the namespace cannot be selected, and simplified the onChange handler.

Text updates:

  • Corrected pluralization of the running instances text in the SourcesList component. [1] [2]

404 error page:

  • Updated the 404 error page HTML content to ensure it displays correctly.

JavaScript chunks:

  • Removed unnecessary code from the frontend/webapp/dep-out/_next/static/chunks/305-80ab836000a4f9a3.js file.

BenElferink and others added 8 commits November 20, 2024 17:15
@BenElferink @alonkeyval
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok @dovzhikova @david336362 @edeNFed
[GEN-1754]: namespace "select all" -> close the accordion (#1797)
06d802d 
Co-authored-by: Alon Braymok <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
Co-authored-by: yodigos <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: alonbraymok <[email protected]>
Co-authored-by: Daria Dovzhikova <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Eden Federman <[email protected]>
@BenElferink @alonkeyval
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok @dovzhikova @david336362 @edeNFed
[GEN-1755]: disable "select all" for empty namespaces (#1798)
f1dbca5 
Co-authored-by: Alon Braymok <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
Co-authored-by: yodigos <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: alonbraymok <[email protected]>
Co-authored-by: Daria Dovzhikova <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Eden Federman <[email protected]>
@BenElferink @alonkeyval
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok @dovzhikova @david336362 @edeNFed
[GEN-1753]: proper English for "running instance(s)" (#1800)
e48b1ca 
Co-authored-by: Alon Braymok <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
Co-authored-by: yodigos <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: alonbraymok <[email protected]>
Co-authored-by: Daria Dovzhikova <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Eden Federman <[email protected]>
@BenElferink @alonkeyval
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok @dovzhikova @david336362 @edeNFed
[GEN-1756]: show all namespaces even with the "select all" filter on (#…
c01fbab 
…1799)

Co-authored-by: Alon Braymok <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
Co-authored-by: yodigos <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: alonbraymok <[email protected]>
Co-authored-by: Daria Dovzhikova <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Eden Federman <[email protected]>
@BenElferink @alonkeyval
@tamirdavid1 @blumamir @RonFed @damemi @alonbraymok @dovzhikova @david336362 @edeNFed
[GEN-1783]: do not apply edges if there are no sources/destinations (#…
57ebfe6 
…1802)

Co-authored-by: Alon Braymok <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: alonbraymok <[email protected]>
Co-authored-by: Daria Dovzhikova <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Eden Federman <[email protected]>
@BenElferink @alonkeyval
@tamirdavid1 @blumamir @RonFed @damemi @alonbraymok @dovzhikova @david336362 @edeNFed
[GEN-1791]: unfocus/blur docs button after window.open() (#1801)
141db03 
Co-authored-by: Alon Braymok <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: alonbraymok <[email protected]>
Co-authored-by: Daria Dovzhikova <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Eden Federman <[email protected]>
@BenElferink @alonkeyval
@tamirdavid1 @blumamir @RonFed @damemi @alonbraymok @dovzhikova @david336362 @edeNFed
[GEN-1768]: fix value and label for "bytes" (#1803)
572d477 
Co-authored-by: Alon Braymok <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Ron Federman <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: alonbraymok <[email protected]>
Co-authored-by: Daria Dovzhikova <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Eden Federman <[email protected]>
@alonkeyval @alonbraymok
@tamirdavid1 @blumamir @damemi
Refactor old UI onboarding issue (#1805)
c7da6c7 
This pull request includes various changes to the codebase, focusing on
updating dependencies, modifying configuration files, and enhancing the
autoscaler controllers. The most important changes include updating the
GitHub Actions workflow, modifying the autoscaler controllers to use a
new configuration structure, and adding tooltips to the ClickHouse
destination configuration.

### Dependency Updates:
* Updated GitHub Actions workflow to use `actions/upload-artifact@v4`
and `actions/download-artifact@v4` instead of version 3.
(`.github/workflows/e2e.yaml`)
[[1]](diffhunk://#diff-a2de7550554c0198ac7f959c78a19ee0996921c98034411de47a7dd49b0c209bL36-R36)
[[2]](diffhunk://#diff-a2de7550554c0198ac7f959c78a19ee0996921c98034411de47a7dd49b0c209bL53-R53)
[[3]](diffhunk://#diff-a2de7550554c0198ac7f959c78a19ee0996921c98034411de47a7dd49b0c209bL118-R126)

### Autoscaler Controllers:
* Modified the `ControllerConfig` structure to replace
`MetricsServerEnabled` with `K8sVersion`.
(`autoscaler/controllers/controller_config/controller_config.go`)
* Updated the `Sync` function in `gateway/root.go` to use the new
`ControllerConfig` structure and handle different Kubernetes versions
for HorizontalPodAutoscaler. (`autoscaler/controllers/gateway/root.go`)
[[1]](diffhunk://#diff-2ba6282ac967de2b88842bb163d61459b2f8f576a8f2e6be8e4c163d4244acd6L25-R26)
[[2]](diffhunk://#diff-2ba6282ac967de2b88842bb163d61459b2f8f576a8f2e6be8e4c163d4244acd6L58-R59)
[[3]](diffhunk://#diff-2ba6282ac967de2b88842bb163d61459b2f8f576a8f2e6be8e4c163d4244acd6L71-R72)
[[4]](diffhunk://#diff-2ba6282ac967de2b88842bb163d61459b2f8f576a8f2e6be8e4c163d4244acd6L107-L112)
* Removed the `isMetricsServerInstalled` function from `main.go` and
updated the main function to use the new `ControllerConfig`.
(`autoscaler/main.go`)
[[1]](diffhunk://#diff-d5a69eecfc7a22bca9e1995f35e1430d7189a034577c73ee10a525abc2f07b26L191-R188)
[[2]](diffhunk://#diff-d5a69eecfc7a22bca9e1995f35e1430d7189a034577c73ee10a525abc2f07b26L295-L312)

### Configuration Files:
* Added tooltips to the ClickHouse destination configuration for better
user guidance. (`destinations/data/clickhouse.yaml`)
[[1]](diffhunk://#diff-44f264f92f35b6a7a0bd00f1f77b39e05aaf84c7d5a17ca79b3bd481f2b36c2aR23-R39)
[[2]](diffhunk://#diff-44f264f92f35b6a7a0bd00f1f77b39e05aaf84c7d5a17ca79b3bd481f2b36c2aR48-R80)

### Codebase Simplification:
* Removed unnecessary imports and cleaned up the code in various files.
(`autoscaler/controllers/gateway/hpa.go`, `autoscaler/main.go`)
[[1]](diffhunk://#diff-fc3f841013645107cfe86f56ee4ebaa7570139ff6487bae3ebbef94f7f1bced3L7-L19)
[[2]](diffhunk://#diff-d5a69eecfc7a22bca9e1995f35e1430d7189a034577c73ee10a525abc2f07b26L25-L26)
[[3]](diffhunk://#diff-d5a69eecfc7a22bca9e1995f35e1430d7189a034577c73ee10a525abc2f07b26L37-L47)

---------

Co-authored-by: alonkeyval <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
@BenElferink BenElferink enabled auto-merge (squash) November 20, 2024 15:36
@BenElferink BenElferink merged commit eb368a7 into main Nov 20, 2024
28 checks passed
@BenElferink BenElferink deleted the beta-ui-bugs-party branch November 20, 2024 16:11
BenElferink added a commit that referenced this pull request Nov 20, 2024
@BenElferink
Revert "Beta UI bugs party (#1807)"
44306d2 
This reverts commit eb368a7.
@BenElferink BenElferink mentioned this pull request Nov 20, 2024
Merged
BenElferink added a commit that referenced this pull request Nov 20, 2024
@BenElferink
Revert "Beta UI bugs party" (#1809)
6536c09 
Reverts #1807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonkeyval alonkeyval alonkeyval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenElferink @alonkeyval