Skip to content

Commit

Permalink
fix: set max_recv_msg_size_mib to value in correct units (#1826)
Browse files Browse the repository at this point in the history
The value in `max_recv_msg_size_mib` for otlp receiver in cluster
collector config should be in alignment with the memory the deployment
has to run.
It was set accidentally to `128 * 1024 * 1024` (e.g. value in bytes),
instead of intended `128` which is a reasonable number to use.

before this change, the value being populated in the config would be
`134217728` MiB which makes no sense
  • Loading branch information
blumamir authored Nov 23, 2024
1 parent d6df850 commit dc56a0b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion common/config/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func getBasicConfig(memoryLimiterConfig GenericMap) (*Config, []string) {
"protocols": GenericMap{
"grpc": GenericMap{
// setting it to a large value to avoid dropping batches.
"max_recv_msg_size_mib": 128 * 1024 * 1024,
"max_recv_msg_size_mib": 128,
"endpoint": "0.0.0.0:4317",
},
// Node collectors send in gRPC, so this is probably not needed
Expand Down
2 changes: 1 addition & 1 deletion common/config/testdata/debugexporter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ receivers:
protocols:
grpc:
endpoint: 0.0.0.0:4317
max_recv_msg_size_mib: 134217728
max_recv_msg_size_mib: 128
http:
endpoint: 0.0.0.0:4318
exporters:
Expand Down
2 changes: 1 addition & 1 deletion common/config/testdata/minimal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ receivers:
protocols:
grpc:
endpoint: 0.0.0.0:4317
max_recv_msg_size_mib: 134217728
max_recv_msg_size_mib: 128
http:
endpoint: 0.0.0.0:4318
exporters: {}
Expand Down

0 comments on commit dc56a0b

Please sign in to comment.