[GEN-1786]: fix max value for "ErrorSampler" (#1815)

odigos-io · Nov 21, 2024 · a1d4e66 · a1d4e66
1 parent 2a43875
commit a1d4e66
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/frontend/webapp/containers/main/actions/choose-action-body/custom-fields/error-sampler.tsx b/frontend/webapp/containers/main/actions/choose-action-body/custom-fields/error-sampler.tsx
@@ -17,11 +17,7 @@ const ErrorSampler: React.FC<Props> = ({ value, setValue }) => {
   const mappedValue = useMemo(() => safeJsonParse<Parsed>(value, { fallback_sampling_ratio: 0 }).fallback_sampling_ratio, [value]);
 
   const handleChange = (val: string) => {
-    let num = Number(val);
-
-    if (Number.isNaN(num) || num < MIN || num > MAX) {
-      num = MIN;
-    }
+    const num = Math.max(MIN, Math.min(Number(val), MAX)) || MIN;
 
     const payload: Parsed = {
       fallback_sampling_ratio: num,