Set GOMAXPROCS according to the cpu limit in data-collection (#2347)

Similar to #1989 but for the data collection. --------- Co-authored-by: Amir Blum <[email protected]>
odigos-io · Jan 30, 2025 · 6e75b40 · 6e75b40
1 parent ca13f98
commit 6e75b40
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/autoscaler/controllers/datacollection/daemonset.go b/autoscaler/controllers/datacollection/daemonset.go
@@ -322,6 +322,19 @@ func getDesiredDaemonSet(datacollection *odigosv1.CollectorsGroup,
 									Name:  "GOMEMLIMIT",
 									Value: fmt.Sprintf("%dMiB", datacollection.Spec.ResourcesSettings.GomemlimitMiB),
 								},
+								{
+									// let the Go runtime know how many CPUs are available,
+									// without this, Go will assume all the cores are available.
+									Name: "GOMAXPROCS",
+									ValueFrom: &corev1.EnvVarSource{
+										ResourceFieldRef: &corev1.ResourceFieldSelector{
+											ContainerName: containerName,
+											// limitCPU, Kubernetes automatically rounds up the value to an integer
+											// (700m -> 1, 1200m -> 2)
+											Resource: "limits.cpu",
+										},
+									},
+								},
 							},
 							LivenessProbe: &corev1.Probe{
 								ProbeHandler: corev1.ProbeHandler{

diff --git a/tests/common/assert/pipeline-ready.yaml b/tests/common/assert/pipeline-ready.yaml
@@ -165,6 +165,12 @@ spec:
                   fieldPath: metadata.name
             - name: GOMEMLIMIT
               (value != null): true
+            - name: GOMAXPROCS
+              valueFrom:
+                resourceFieldRef:
+                  containerName: data-collection
+                  divisor: "0"
+                  resource: limits.cpu
           resources:
             requests:
               (memory != null): true