chore: move profiles manifest files to profiles module (#2193)

profiles manifests are currently hosted in cli module.

this PR moves them to the `profiles` module, so they can later be
consumed and apply as a reconciliation in sschedualer.

It will also help maintainability to have all profiles definitions in
one place instead of having the profile info in one module and manifests
in another

cli/cmd/resources/profiles.go

@@ -4,24 +4,24 @@ import (
 	"context"
 	"fmt"
 
-	cliprofiles "github.com/odigos-io/odigos/cli/cmd/resources/profiles"
 	"github.com/odigos-io/odigos/cli/cmd/resources/resourcemanager"
 	"github.com/odigos-io/odigos/cli/pkg/kube"
 	"github.com/odigos-io/odigos/common"
 	"github.com/odigos-io/odigos/profiles"
+	"github.com/odigos-io/odigos/profiles/manifests"
 	"github.com/odigos-io/odigos/profiles/profile"
 )
 
-func GetResourcesForProfileName(profileName common.ProfileName, tier common.OdigosTier) ([]kube.Object, error) {
+func GetResourcesForProfileName(profileName common.ProfileName, tier common.OdigosTier) ([]profile.K8sObject, error) {
 	allAvailableProfiles := GetAvailableProfilesForTier(tier)
 	for _, p := range allAvailableProfiles {
 		if p.ProfileName == common.ProfileName(profileName) {
 			if p.KubeObject != nil {
 				filename := fmt.Sprintf("%s.yaml", profileName)
-				return cliprofiles.GetEmbeddedYAMLFileAsObjects(filename, p.KubeObject)
+				return manifests.GetEmbeddedResourceManifestsAsObjects(filename, p.KubeObject)
 			}
 			if len(p.Dependencies) > 0 {
-				allResources := []kube.Object{}
+				allResources := []profile.K8sObject{}
 				for _, dep := range p.Dependencies {
 					resources, err := GetResourcesForProfileName(dep, tier)
 					if err != nil {
@@ -71,8 +71,8 @@ func (a *profilesResourceManager) InstallFromScratch(ctx context.Context) error
 		}
 		for _, r := range profileResources {
 			r.SetNamespace(a.ns)
+			allResources = append(allResources, r)
 		}
-		allResources = append(allResources, profileResources...)
 	}
 	return a.client.ApplyResources(ctx, a.config.ConfigVersion, allResources)
 }

profiles/go.mod

@@ -6,6 +6,7 @@ require (
 	github.com/odigos-io/odigos/api v0.0.0
 	github.com/odigos-io/odigos/common v0.0.0
 	k8s.io/apimachinery v0.32.0
+	sigs.k8s.io/yaml v1.4.0
 )
 
 require (
@@ -57,7 +58,6 @@ require (
 	sigs.k8s.io/controller-runtime v0.19.0 // indirect
 	sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
-	sigs.k8s.io/yaml v1.4.0 // indirect
 )
 
 replace (

cli/cmd/resources/profiles/render.go → profiles/manifests/render.go

@@ -1,19 +1,19 @@
-package profiles
+package manifests
 
 import (
 	"embed"
 	"fmt"
 	"reflect"
 
-	"github.com/odigos-io/odigos/cli/pkg/kube"
+	"github.com/odigos-io/odigos/profiles/profile"
 	"sigs.k8s.io/yaml"
 )
 
 //go:embed *.yaml
 var embeddedFiles embed.FS
 
-// GetEmbeddedYAMLFileAsObjects is a generic function to read embedded YAML files and convert them into runtime.Object
-func GetEmbeddedYAMLFileAsObjects(filename string, obj kube.Object) ([]kube.Object, error) {
+// GetEmbeddedResourceManifestsAsObjects is a generic function to read embedded YAML files and convert them into runtime.Object
+func GetEmbeddedResourceManifestsAsObjects(filename string, obj profile.K8sObject) ([]profile.K8sObject, error) {
 
 	// Read the embedded YAML file content
 	yamlBytes, err := embeddedFiles.ReadFile(filename)
@@ -31,6 +31,11 @@ func GetEmbeddedYAMLFileAsObjects(filename string, obj kube.Object) ([]kube.Obje
 		return nil, fmt.Errorf("failed to unmarshal YAML: %v", err)
 	}
 
+	k8sObj, ok := newObj.(profile.K8sObject)
+	if !ok {
+		return nil, fmt.Errorf("unmarshaled object is not a k8s object")
+	}
+
 	// Return the object wrapped in a slice
-	return []kube.Object{newObj.(kube.Object)}, nil
+	return []profile.K8sObject{k8sObj}, nil
 }